Split libtorch agnostic tests by feature version by mikaylagawarecki · Pull Request #167803 · pytorch/pytorch

mikaylagawarecki · 2025-11-14T05:15:38Z

Tests are split into libtorch_agnostic_2_9_extension and libtorch_agnostic_2_10_extension depending on the minimum version they should compile+run in

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-11-14T05:15:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167803

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4679f51 with merge base 1c04a43 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99

I'm understanding this is a draft PR for now but I have a q: is it right to expect the diff between 2_9 and 2_10 is 2_9 will have fewer kernels that are not dependent on 2_10?

[ghstack-poisoned]

janeyx99

skimmed, looks fine to me

janeyx99 · 2025-11-17T16:57:15Z

test/cpp_extensions/libtorch_agnostic_2_10_extension/setup.py

-        "cxx": ["-fdiagnostics-color=always"],
+        "cxx": [
+            "-fdiagnostics-color=always",
+            "-DTORCH_STABLE_ONLY",


Suggested change

"-DTORCH_STABLE_ONLY",

we expect users to only need one flag definition

janeyx99 · 2025-11-17T16:58:09Z

test/cpp_extensions/libtorch_agnostic_2_9_extension/setup.py

+    extra_compile_args = {
+        "cxx": [
+            "-fdiagnostics-color=always",
+            "-DTORCH_STABLE_ONLY",


Suggested change

"-DTORCH_STABLE_ONLY",

ghstack-source-id: 7f16341 Pull Request resolved: pytorch/pytorch#167803

Tests are split into libtorch_agnostic_2_9_extension and libtorch_agnostic_2_10_extension depending on the minimum version they should compile+run in [ghstack-poisoned]

pytorchmergebot · 2025-11-18T06:43:50Z

Starting merge as part of PR stack under #167962

…rsion (#167804) Adds a CI workflow that tests the wheel built on current main targeting 2.9 with a 2.9 runtime Pull Request resolved: #167804 Approved by: https://github.com/janeyx99 ghstack dependencies: #168025, #167802, #167803

Splits each torch library registration in the 2.10 folder into its own file -- I had a script that parsed kernel.cpp to do this but I felt like forcing this responsibility on the user might be less error prone Compiles each file targetting 2.9 and asserts that compilation fails. (There are 2 2.9 kernels we use as negative tests where compilation is expected to succeed) Pull Request resolved: #167962 Approved by: https://github.com/janeyx99 ghstack dependencies: #168025, #167802, #167803, #167804

Unclear which PR in the ghstack caused the ROCm failure. Stack was (oldest at bottom): - pytorch#167962 - pytorch#167804 - pytorch#167803 - pytorch#167802 - pytorch#168025

Unclear which PR in the ghstack caused the ROCm failure. Stack was (oldest at bottom): - #167962 - #167804 - #167803 - #167802 - #168025 Fixes the following test: PYTORCH_TEST_WITH_ROCM=1 python test/cpp_extensions/libtorch_agnostic_2_10_extension/test_version_compatibility.py FunctionVersionCompatibilityTest.test_mv_tensor_accessor_cuda_works_with_2_9 Pull Request resolved: #168087 Approved by: https://github.com/jeffdaily, https://github.com/janeyx99 Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com>

~This PR does change the semantics of the >> operator by using STD_TORCH_CHECK to throw the error instead of TORCH_CHECK. Jane (who is writing this message) thinks it is okay because it is the error case when an invalid MemoryFormat or Layout is getting passed into >>, so the UX benefits of TORCH_CHECK over STD_TORCH_CHECK there are not significant enough to warrant making a new copy of Layout and MemoryFormat's >> APIs.~ Never mind! We shouldn't change TORCH_CHECK to STD_TORCH_CHECK for core usage ever, cuz the traceback info and c10::Error is very much desired!! So the solution is to not migrate the >>s. I pushed new commits to the stack to remove the >> code, but for reference, 8a30179 has all the code that I ended up deleting. Pull Request resolved: #168034 Approved by: https://github.com/janeyx99 ghstack dependencies: #168025, #167802, #167803, #167804, #167962 Co-authored-by: Jane Xu <janeyx@meta.com>

ghstack-source-id: 5c9196a Pull Request resolved: pytorch/pytorch#167803

Split libtorch agnostic tests by feature version

65708c0

[ghstack-poisoned]

pytorch-bot bot added the topic: not user facing topic category label Nov 14, 2025

This was referenced Nov 13, 2025

Add empty to stable ops #167592

Closed

Add reshape, view, flatten to torch/csrc/stable #167600

Closed

Fix TORCH_FEATURE_VERSION guards #167802

Closed

Test libtorch_agnostic with TORCH_TARGET_VERSION on target pytorch version #167804

Closed

janeyx99 reviewed Nov 14, 2025

View reviewed changes

mikaylagawarecki added 3 commits November 16, 2025 17:29

Update on "Split libtorch agnostic tests by feature version"

d6f5661

[ghstack-poisoned]

Update on "Split libtorch agnostic tests by feature version"

d55a8b3

[ghstack-poisoned]

Update on "Split libtorch agnostic tests by feature version"

0c97dc7

[ghstack-poisoned]

mikaylagawarecki mentioned this pull request Nov 17, 2025

Test that TORCH_FEATURE_VERSION guards are used where needed #167962

Closed

Update on "Split libtorch agnostic tests by feature version"

92c6571

[ghstack-poisoned]

mikaylagawarecki mentioned this pull request Nov 17, 2025

Demonstrate something that would fail the libtorch_agnostic_targetting workflow due to missing version guards #167964

Closed

mikaylagawarecki marked this pull request as ready for review November 17, 2025 16:31

mikaylagawarecki requested a review from a team as a code owner November 17, 2025 16:31

janeyx99 approved these changes Nov 17, 2025

View reviewed changes

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025

Split libtorch agnostic tests by feature version

dc4cb30

ghstack-source-id: 7f16341 Pull Request resolved: pytorch/pytorch#167803

This was referenced Nov 17, 2025

Move MemoryFormat/Layout to headeronly #168034

Closed

Add sum and sum_out to stable ops #168062

Closed

Update on "Split libtorch agnostic tests by feature version"

4679f51

Tests are split into libtorch_agnostic_2_9_extension and libtorch_agnostic_2_10_extension depending on the minimum version they should compile+run in [ghstack-poisoned]

mikaylagawarecki mentioned this pull request Nov 17, 2025

Follow up on #161891 move additions to stable shim and use version guards #168025

Closed

pytorchmergebot closed this in 4c127f1 Nov 18, 2025

pytorchmergebot added the Merged label Nov 18, 2025

amdfaa mentioned this pull request Nov 18, 2025

[ROCm][CI] forward fix libtorch agnostic tests #168087

Closed

This was referenced Nov 19, 2025

Test that TORCH_FEATURE_VERSION guards are used where needed qodo-benchmark/pytorch#1

Open

Test that TORCH_FEATURE_VERSION guards are used where needed qodo-benchmark/pytorch#2

Open

bar-qodo mentioned this pull request Nov 19, 2025

Test that TORCH_FEATURE_VERSION guards are used where needed qodo-benchmark/pytorch#4

Open

tomerqodo mentioned this pull request Nov 20, 2025

Test that TORCH_FEATURE_VERSION guards are used where needed qodo-benchmark/pytorch#5

Open

bar-qodo mentioned this pull request Nov 20, 2025

Test that TORCH_FEATURE_VERSION guards are used where needed qodo-benchmark/pytorch#6

Open

tiendatngcs pushed a commit to tiendatngcs/pytorch-Dec25 that referenced this pull request Dec 9, 2025

Split libtorch agnostic tests by feature version

70793af

ghstack-source-id: 5c9196a Pull Request resolved: pytorch/pytorch#167803

github-actions bot deleted the gh/mikaylagawarecki/377/head branch December 19, 2025 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split libtorch agnostic tests by feature version#167803

Split libtorch agnostic tests by feature version#167803
mikaylagawarecki wants to merge 6 commits intogh/mikaylagawarecki/377/basefrom
gh/mikaylagawarecki/377/head

mikaylagawarecki commented Nov 14, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

janeyx99 left a comment •

edited

Loading

Uh oh!

janeyx99 left a comment

Uh oh!

janeyx99 Nov 17, 2025

Uh oh!

janeyx99 Nov 17, 2025

Uh oh!

pytorchmergebot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mikaylagawarecki commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167803

✅ No Failures

Uh oh!

janeyx99 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

janeyx99 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

janeyx99 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mikaylagawarecki commented Nov 14, 2025 •

edited

Loading

pytorch-bot bot commented Nov 14, 2025 •

edited

Loading

janeyx99 left a comment •

edited

Loading