[inductor] fix the decision of inner reduction#167697
[inductor] fix the decision of inner reduction#167697shunting314 wants to merge 4 commits intogh/shunting314/262/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167697
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 6f6f780 with merge base b7f5277 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The label |
|
The label |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
|
The label |
|
The label |
|
The label |
|
@pytorchbot merge |
Inductor may treat an outer reduction as inner reduction when the reduction ranges contains a 1. This cause some weird issue that we skip fusing with mix order reduction. While I'm still debugging why that happens, I think we should fix the decision here anyways cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
ghstack-source-id: 1304bd8 Pull Request resolved: pytorch/pytorch#167697
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "break internal tests, need to include internal changes" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 689d731. Reverted #167697 on behalf of https://github.com/yangw-dev due to break internal tests, need to include internal changes ([comment](#167697 (comment)))
|
@shunting314 your PR has been successfully reverted. |
Summary: reland #167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489
Summary: reland pytorch#167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489
|
@PaulZhang12 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: reland #167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489
Summary: reland #167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489
Summary: reland #167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489 Pull Request resolved: #168391 Approved by: https://github.com/desertfire
|
Relanded from fbcode #168391 |
This reverts commit 689d731. Reverted #167697 on behalf of https://github.com/yangw-dev due to break internal tests, need to include internal changes ([comment](#167697 (comment)))
Summary: reland #167697 from fbcode. Test Plan: CI and new tests. Differential Revision: D87678489 Pull Request resolved: #168391 Approved by: https://github.com/desertfire
Stack from ghstack (oldest at bottom):
Inductor may treat an outer reduction as inner reduction when the reduction ranges contains a 1. This cause some weird issue that we skip fusing with mix order reduction. While I'm still debugging why that happens, I think we should fix the decision here anyways
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben
Differential Revision: D87788062