Fix different seq length by Microve · Pull Request #167481 · pytorch/pytorch

Microve · 2025-11-10T20:42:26Z

Differential Revision: D86685546

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @chenyang78

pytorch-bot · 2025-11-10T20:42:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167481

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit 6e78f15 with merge base 8cf0bdd ():

NEW FAILURE - The following job has failed:

Lint / lintrunner-pyrefly-all / linux-job (gh)
>>> Lint for torch/_inductor/scheduler.py:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx) (gh) (trunk failure)
stable_diffusion_unet
inductor / inductor-cpu-test / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx) (gh) (trunk failure)
stable_diffusion_unet
inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
stable_diffusion_unet

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable) (gh) (#166072)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-10T20:42:34Z

@Microve has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86685546.

Microve · 2025-11-11T05:25:59Z

@pytorchbot label "topic: not user facing"

…ributed_ranks (pytorch#167481) Summary: `align_runtime_estimations_across_all_distributed_ranks` is only needed when there are collectives in the graph. If there are no collectives, since Partitioner may make different decisions on the saved tensors. It could potentially cause failure in `runtime_estimations_align_across_all_distributed_ranks` Test Plan: Without this change, the job could fail because the different number of nodes in the backward graph: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-9990706fc5?job_attempt=0&version=0&tab=summary&env=PRODUCTION tlparse of 16/3 in rank 113: https://fburl.com/3cxltwt4 tlparse of 16/3 in rank 124: https://fburl.com/p1grio09 With this change, it can run without hanging: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-c2323f01c2?job_attempt=0&version=0&tab=summary&env=PRODUCTION Reviewed By: IvanKobzarev Differential Revision: D86685546

…ributed_ranks (pytorch#167481) Summary: `align_runtime_estimations_across_all_distributed_ranks` is only needed when there are collectives in the graph. If there are no collectives, since Partitioner may make different decisions on the saved tensors. It could potentially cause failure in `runtime_estimations_align_across_all_distributed_ranks` Test Plan: Without this change, the job could fail because the different number of nodes in the backward graph: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-9990706fc5?job_attempt=0&version=0&tab=summary&env=PRODUCTION tlparse of 16/3 in rank 113: https://fburl.com/3cxltwt4 tlparse of 16/3 in rank 124: https://fburl.com/p1grio09 With this change, it can run without hanging: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-c2323f01c2?job_attempt=0&version=0&tab=summary&env=PRODUCTION Reviewed By: IvanKobzarev, eellison Differential Revision: D86685546

eellison

Looks good, need to fix lint

…ributed_ranks (#167481) Summary: `align_runtime_estimations_across_all_distributed_ranks` is only needed when there are collectives in the graph. If there are no collectives, since Partitioner may make different decisions on the saved tensors. It could potentially cause failure in `runtime_estimations_align_across_all_distributed_ranks` Test Plan: Without this change, the job could fail because the different number of nodes in the backward graph: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-9990706fc5?job_attempt=0&version=0&tab=summary&env=PRODUCTION tlparse of 16/3 in rank 113: https://fburl.com/3cxltwt4 tlparse of 16/3 in rank 124: https://fburl.com/p1grio09 With this change, it can run without hanging: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-c2323f01c2?job_attempt=0&version=0&tab=summary&env=PRODUCTION Reviewed By: IvanKobzarev, eellison Differential Revision: D86685546

…ributed_ranks (pytorch#167481) Summary: `align_runtime_estimations_across_all_distributed_ranks` is only needed when there are collectives in the graph. If there are no collectives, since Partitioner may make different decisions on the saved tensors. It could potentially cause failure in `runtime_estimations_align_across_all_distributed_ranks` Test Plan: Without this change, the job could fail because the different number of nodes in the backward graph: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-9990706fc5?job_attempt=0&version=0&tab=summary&env=PRODUCTION tlparse of 16/3 in rank 113: https://fburl.com/3cxltwt4 tlparse of 16/3 in rank 124: https://fburl.com/p1grio09 With this change, it can run without hanging: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-aps-fb_him_sfsdp_h100-c2323f01c2?job_attempt=0&version=0&tab=summary&env=PRODUCTION Reviewed By: IvanKobzarev, eellison Differential Revision: D86685546

facebook-github-bot · 2025-11-14T05:17:35Z

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

pytorchmergebot · 2025-11-14T05:19:33Z

Merge started

Your change will be merged while ignoring the following 5 checks: Lint / lintrunner-pyrefly-all / linux-job, inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx), inductor / inductor-cpu-test / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx), inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-auto-revert · 2025-11-14T06:04:15Z

@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert

This PR is attributed to have caused regression in:

Lint: lintrunner-pyrefly-all / linux-job (hud)

Please investigate and fix the issues.

pytorchmergebot · 2025-11-14T06:05:43Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit c78e646. Reverted #167481 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#167481 (comment)))

pytorchmergebot · 2025-11-14T06:05:49Z

@Microve your PR has been successfully reverted.

Differential Revision: D86685546 Pull Request resolved: pytorch#167481 Approved by: https://github.com/eellison

This reverts commit c78e646. Reverted pytorch#167481 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](pytorch#167481 (comment)))

Differential Revision: D87413883

Summary: Pull Request resolved: pytorch#168144 Test Plan: Tests are in D86685546 Differential Revision: D87413883

Differential Revision: D87413883 Pull Request resolved: #168144 Approved by: https://github.com/eellison

github-actions · 2026-01-17T20:37:26Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

pytorch-bot bot added ciflow/inductor module: inductor labels Nov 10, 2025

meta-codesync bot added fb-exported meta-exported labels Nov 10, 2025

Microve force-pushed the export-D86685546 branch from 6f73eb4 to 5ca3182 Compare November 11, 2025 04:11

pytorch-bot bot added the topic: not user facing topic category label Nov 11, 2025

Microve force-pushed the export-D86685546 branch from 5ca3182 to df611d3 Compare November 11, 2025 18:52

Microve force-pushed the export-D86685546 branch from df611d3 to 7e3172e Compare November 11, 2025 20:02

Microve force-pushed the export-D86685546 branch from 7e3172e to aa03700 Compare November 12, 2025 00:01

Microve requested review from IvanKobzarev and eellison November 12, 2025 01:19

Microve force-pushed the export-D86685546 branch from aa03700 to 164f3e9 Compare November 12, 2025 01:20

eellison approved these changes Nov 12, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2025

Microve force-pushed the export-D86685546 branch from 164f3e9 to ce791aa Compare November 12, 2025 22:47

Microve force-pushed the export-D86685546 branch from ce791aa to 7bdd2b4 Compare November 12, 2025 23:32

Microve force-pushed the export-D86685546 branch from 7bdd2b4 to a4c9093 Compare November 13, 2025 00:09

Microve force-pushed the export-D86685546 branch from a4c9093 to 6e78f15 Compare November 14, 2025 01:27

pytorchmergebot added the merging label Nov 14, 2025

pytorchmergebot closed this in c78e646 Nov 14, 2025

pytorchmergebot added Merged and removed merging labels Nov 14, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 14, 2025

pytorchmergebot reopened this Nov 14, 2025

Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025

Fix different seq length (pytorch#167481)

9890213

Differential Revision: D86685546 Pull Request resolved: pytorch#167481 Approved by: https://github.com/eellison

eellison approved these changes Nov 18, 2025

View reviewed changes

pytorch-bot bot pushed a commit that referenced this pull request Nov 19, 2025

Reland"Fix different seq length (#167481)"

469bf6b

Differential Revision: D87413883

Microve added a commit to Microve/pytorch that referenced this pull request Nov 19, 2025

Reland"Fix different seq length (pytorch#167481)" (pytorch#168144)

c793ab5

Summary: Pull Request resolved: pytorch#168144 Test Plan: Tests are in D86685546 Differential Revision: D87413883

pytorchmergebot pushed a commit that referenced this pull request Nov 20, 2025

Reland"Fix different seq length (#167481)" (#168144)

6fa7791

Differential Revision: D87413883 Pull Request resolved: #168144 Approved by: https://github.com/eellison

JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025

Reland"Fix different seq length (#167481)" (#168144)

4e8b4bb

Differential Revision: D87413883 Pull Request resolved: #168144 Approved by: https://github.com/eellison

github-actions bot added the Stale label Jan 17, 2026

github-actions bot closed this Feb 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix different seq length#167481

Fix different seq length#167481
Microve wants to merge 1 commit intopytorch:mainfrom
Microve:export-D86685546

Microve commented Nov 10, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

meta-codesync bot commented Nov 10, 2025

Uh oh!

Microve commented Nov 11, 2025

Uh oh!

eellison left a comment

Uh oh!

facebook-github-bot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Uh oh!

pytorch-auto-revert bot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Microve commented Nov 10, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167481

❌ 1 New Failure, 4 Unrelated Failures

Uh oh!

meta-codesync bot commented Nov 10, 2025

Uh oh!

Microve commented Nov 11, 2025

Uh oh!

eellison left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Merge started

Uh oh!

pytorch-auto-revert bot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Uh oh!

pytorchmergebot commented Nov 14, 2025

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Microve commented Nov 10, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Nov 10, 2025 •

edited

Loading