Add Tests#167392
Closed
drisspg wants to merge 18 commits intogh/drisspg/220/basefrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167392
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a9c6a8f with merge base e401a56 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 8, 2025
Closed
albanD
reviewed
Nov 11, 2025
jbschlosser
reviewed
Nov 12, 2025
Comment on lines
+214
to
+215
| # TODO: Getting bad TMA setup on dO w/ headdim = 64, will take a look | ||
| test_backward = head_dim == 128 and dtype == torch.float16 |
Contributor
There was a problem hiding this comment.
nit: xfailing this case would be cleaner
Contributor
Author
There was a problem hiding this comment.
played around with this but I think its better as is because we are at least testing the forward here, and I am confident on how stable the bwd errror is to assert on it
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: f7dccad Pull-Request: pytorch/pytorch#167392
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Need to wait for: Dao-AILab/flash-attention#1998 to land Pull Request resolved: pytorch#167392 Approved by: https://github.com/jbschlosser ghstack dependencies: pytorch#167348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Need to wait for:
Dao-AILab/flash-attention#1998 to land