Add basic spin linting documentation#167227
Closed
zklaus wants to merge 13 commits intogh/zklaus/20/basefrom
Closed
Add basic spin linting documentation#167227zklaus wants to merge 13 commits intogh/zklaus/20/basefrom
zklaus wants to merge 13 commits intogh/zklaus/20/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167227
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2a4cd86 with merge base 1c0bf2a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 11, 2025
atalman
approved these changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
lgtm.
Please fix:
Lint / toc / linux-job (gh)
RuntimeError: Command docker exec -t f3ec47bb60cbb50cae0b19bba0eafb4e8621537a13d2f38a4f7ca1f24f2f5ab5 /exec failed with exit code 1
albanD
approved these changes
Nov 13, 2025
| * ... | ||
| * [.circleci](.circleci) - CircleCI configuration management. [README](.circleci/README.md) | ||
|
|
||
| ## Spin |
Collaborator
There was a problem hiding this comment.
Can we remove/move to legacy the exiting doc about linting?
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: e6e8f10 Pull-Request: pytorch/pytorch#167227
albanD
approved these changes
Nov 19, 2025
Collaborator
albanD
left a comment
There was a problem hiding this comment.
Sounds ok, but let's clean up old info asap
Collaborator
|
Starting merge as part of PR stack under #167551 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Pull Request resolved: #167551 Approved by: https://github.com/Skylion007, https://github.com/albanD, https://github.com/atalman ghstack dependencies: #167227
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This adds basic documentation of the linting features for Spin added in #167226 to the CONTRIBUTING.md document. Pull Request resolved: #167227 Approved by: https://github.com/atalman, https://github.com/albanD
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
Pull Request resolved: #167551 Approved by: https://github.com/Skylion007, https://github.com/albanD, https://github.com/atalman ghstack dependencies: #167227
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 9, 2025
ghstack-source-id: 69eab14 Pull-Request: pytorch/pytorch#167227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic documentation of the linting features for Spin added in #167226 to the CONTRIBUTING.md document.
Stack from ghstack (oldest at bottom):