Skip to content

Use ubuntu:24.04 as base image for devel#166907

Closed
tinglvv wants to merge 2 commits intopytorch:mainfrom
tinglvv:fix-devel-base-image
Closed

Use ubuntu:24.04 as base image for devel#166907
tinglvv wants to merge 2 commits intopytorch:mainfrom
tinglvv:fix-devel-base-image

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Nov 3, 2025

Issue - #166897
Currently the devel release image uses nvidia/cuda docker as base, we should not be blocked by the CUDA release process and should switch away from using nvidia/cuda docker as base.

cc @atalman @malfet @ptrblck @nWEIdia

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166907

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit 486eb0e with merge base 77da53a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 3, 2025
@malfet
Copy link
Contributor

malfet commented Nov 3, 2025

LGTM, but would be good to have a test plan of sorts (i.e. one can run container and build say flash attention inside)

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for test plan

@atalman atalman added this to the 2.11 milestone Dec 5, 2025
@tinglvv tinglvv force-pushed the fix-devel-base-image branch from 372a402 to fb6a1ec Compare January 23, 2026 18:49
@tinglvv tinglvv changed the title Use ubuntu:22.04 as base image for devel Use ubuntu:24.04 as base image for devel Jan 30, 2026
@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 30, 2026

Regarding test plan:

Pass/Fail Criteria

Test Pass Criteria Status
Build devel image CI passes
CPU wheel build USE_CUDA=0 python setup.py bdist_wheel creates wheel in dist/
CUDA wheel build python setup.py bdist_wheel creates wheel with CUDA support
Test wheels work (PyTorch imports/CUDA available) import torch succeeds and basic ops pass
Runtime image check if runtime image has any issues (no regression)

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 31, 2026

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix-devel-base-image onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-devel-base-image && git pull --rebase)

@tinglvv
Copy link
Collaborator Author

tinglvv commented Feb 2, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 2, 2026
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

radeksm pushed a commit to radeksm/pytorch that referenced this pull request Feb 20, 2026
Issue - pytorch#166897
Currently the devel release image uses nvidia/cuda docker as base, we should not be blocked by the CUDA release process and should switch away from using nvidia/cuda docker as base.

Pull Request resolved: pytorch#166907
Approved by: https://github.com/malfet, https://github.com/atalman
libohao1201 pushed a commit to libohao1201/pytorch that referenced this pull request Mar 2, 2026
Issue - pytorch#166897
Currently the devel release image uses nvidia/cuda docker as base, we should not be blocked by the CUDA release process and should switch away from using nvidia/cuda docker as base.

Pull Request resolved: pytorch#166907
Approved by: https://github.com/malfet, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants