Silent XNNPACK GCC14 warnings#166873
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166873
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 428596f with merge base 285779b ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
You need to add the word submodule to the PR or PR description of CI will yell at you. |
|
Ahhh these errors come from the new XNNPack version. |
|
It looks like the This is a blocker for updating to GCC14. |
|
We have two options here:
@Skylion007 @malfet - I appreciate your opinions on this. |
|
cc: @kimishpatel do you think we can revert #43602 ? (Have no context why it was added or whether its used) |
Was it just renamed or something? |
|
As per the message above, I now just silence the warnings instead of updating XNNPACK, this allows us to build XNNPACK with gcc14 without an issue. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / libtorch-linux-jammy-cuda12.8-py3.10-gcc11-debug / build Details for Dev Infra teamRaised by workflow job |
|
This failure is unrelated: trunk / libtorch-linux-jammy-cuda12.8-py3.10-gcc11-debug / build (push) |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot --help |
PyTorchBot HelpMergeRevertRebaseLabelDr CIcherry-pick |
|
@pytorchbot merge --ignore-current |
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes: #149828,#167642 and allows us to update to GCC14 Pull Request resolved: #166873 Approved by: https://github.com/malfet
Fixes: #149828 and #167642 ghstack-source-id: 790cc33 Pull-Request: pytorch/pytorch#166873
Stack from ghstack (oldest at bottom):
Fixes: #149828,#167642 and allows us to update to GCC14
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @aditew01 @snadampal @milpuz01 @nikhil-arm @nWEIdia