add peephole connections to LSTM and LSTMCell in AutogradRNN#1665
Closed
david-leon wants to merge 1 commit intopytorch:masterfrom
Closed
add peephole connections to LSTM and LSTMCell in AutogradRNN#1665david-leon wants to merge 1 commit intopytorch:masterfrom
LSTM and LSTMCell in AutogradRNN#1665david-leon wants to merge 1 commit intopytorch:masterfrom
Conversation
|
Greetings! I apologize to dig up this ancient pull request but were there any reasons this hasn't been merged, apart from the basic linter errors? I realize nobody uses peepholes anymore and the implementation is a slow kludge but I've got some legacy nets I'd like to run alongside newer rnns. If it's out of the question I'll just put autograd implementation directly into my project. |
wrg, no sorry for such or anyx, any is ok |
Contributor
|
RNN got ported to C++, so unfortunately this PR would have to be redone on the C++ implementation. CC @apaszke |
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jan 15, 2019
…827566 Summary: Previous import was 7abd834091f1024c11749dcfd25126802db9fdd5 Included changes: - **[84a0441](onnx/onnx@84a0441)**: Clarify namescopes in the presence of nested subgraphs (pytorch#1665) <G. Ramalingam> - **[118fec5](onnx/onnx@118fec5)**: Add Where op. (pytorch#1569) <Sergii Dymchenko> - **[beefa15](onnx/onnx@beefa15)**: Use strings directly for casing as np.object w/o redundant StringHolder. (pytorch#1736) <Dmitri Smirnov> - **[4023bae](onnx/onnx@4023bae)**: Add a capability to input/output unicode strings (pytorch#1734) <Dmitri Smirnov> - **[1a8a7fc](onnx/onnx@1a8a7fc)**: typos fixed: iutput -> input (pytorch#1726) <Beomsoo Kim> - **[0128478](onnx/onnx@0128478)**: Scan test update (pytorch#1732) <G. Ramalingam> - **[c6a24fd](onnx/onnx@c6a24fd)**: turn rtol to 0.002 on densenet121, since AMD and Nvidia GPU's precion difference (pytorch#1733) <Lu Fang> - **[5b7ac72](onnx/onnx@5b7ac72)**: Add Shrink operator (pytorch#1622) <Rui Zhu> Differential Revision: D13676711 fbshipit-source-id: 0b7b8a398afa4a3b54752fb792f19e7efca80f65
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 16, 2019
…827566 (#16046) Summary: Pull Request resolved: #16046 Previous import was 7abd834091f1024c11749dcfd25126802db9fdd5 Included changes: - **[84a0441](onnx/onnx@84a0441)**: Clarify namescopes in the presence of nested subgraphs (#1665) <G. Ramalingam> - **[118fec5](onnx/onnx@118fec5)**: Add Where op. (#1569) <Sergii Dymchenko> - **[beefa15](onnx/onnx@beefa15)**: Use strings directly for casing as np.object w/o redundant StringHolder. (#1736) <Dmitri Smirnov> - **[4023bae](onnx/onnx@4023bae)**: Add a capability to input/output unicode strings (#1734) <Dmitri Smirnov> - **[1a8a7fc](onnx/onnx@1a8a7fc)**: typos fixed: iutput -> input (#1726) <Beomsoo Kim> - **[0128478](onnx/onnx@0128478)**: Scan test update (#1732) <G. Ramalingam> - **[c6a24fd](onnx/onnx@c6a24fd)**: turn rtol to 0.002 on densenet121, since AMD and Nvidia GPU's precion difference (#1733) <Lu Fang> - **[5b7ac72](onnx/onnx@5b7ac72)**: Add Shrink operator (#1622) <Rui Zhu> Reviewed By: yinghai Differential Revision: D13676711 fbshipit-source-id: 513cc137223469b47af48919432aaecf58006012
zasdfgbnm
pushed a commit
that referenced
this pull request
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to discussion, add peephole connections to the autograd version of
LSTMandLSTMCell.For backward compatibility, the parameter
peepholesis set toFalseby default.