[MPS][1/N] Fix unsupported dtypes error checking for some MPS ops#166273
Closed
malfet wants to merge 11 commits intogh/malfet/575/basefrom
Closed
[MPS][1/N] Fix unsupported dtypes error checking for some MPS ops#166273malfet wants to merge 11 commits intogh/malfet/575/basefrom
malfet wants to merge 11 commits intogh/malfet/575/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166273
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 53 PendingAs of commit 4336fac with merge base dc4f3c7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 26, 2025
This was referenced Oct 31, 2025
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: c091944 Pull Request resolved: pytorch/pytorch#166273
manuelcandales
approved these changes
Nov 18, 2025
Contributor
Author
|
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
ghstack-source-id: 0cfe35c Pull Request resolved: pytorch/pytorch#166273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Partially vibe-coded with ClaudeCode, and changes following ops (summary also created by Claude):
Activation operations: Added checks rejecting Long, Complex, and Bool types for operations like log_softmax, log_sigmoid, mish, softplus, and silu, as MPS doesn't support exponent operations on these types
Linear algebra operations: Restricted linalg_lu_factor, linalg_solve, and linalg_solve_triangular to Float type only (previously only checked for complex types)
Pooling operations: Added checks to reject Complex types for avg_pool2d and max_pool2d operations
Loss functions: Added type checks for nll_loss (Complex), huber_loss (Long, Complex), and grid_sampler_2d (Complex)
Reduction operations:
Other operations:
All checks use
TORCH_CHECK_NOT_IMPLEMENTED