Skip to content

[MPS] Error out when BatchNorm is called for Complex#166215

Closed
malfet wants to merge 9 commits intogh/malfet/572/basefrom
gh/malfet/572/head
Closed

[MPS] Error out when BatchNorm is called for Complex#166215
malfet wants to merge 9 commits intogh/malfet/572/basefrom
gh/malfet/572/head

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Oct 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Or BatchNorm or LayerNorm for Long types

Discovered while trying to enable test_ops.py for MPS

@malfet
Update
540a37c 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner October 25, 2025 00:50
@malfet malfet mentioned this pull request Oct 25, 2025
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Oct 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166215

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 19 Pending

As of commit 3dfb374 with merge base 7692fa0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet mentioned this pull request Oct 25, 2025
Closed
@pytorch-bot pytorch-bot Bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 25, 2025
malfet added a commit that referenced this pull request Oct 25, 2025
@malfet
[MPS] Error out when BatchNorm is called for Complex
47cee22 
Or Long types

Discovered while trying to enable `test_ops.py` for MPS

ghstack-source-id: 6f287da
Pull Request resolved: #166215
@malfet malfet requested review from Skylion007 and dcci October 25, 2025 01:48
@malfet malfet added the topic: bug fixes topic category label Oct 25, 2025
@malfet
Update
82c385e 
[ghstack-poisoned]
This was referenced Oct 26, 2025
Closed
Closed
malfet and others added 4 commits October 26, 2025 18:46
@malfet
Update
587841d 
[ghstack-poisoned]
@malfet
Update
53bb2ed 
[ghstack-poisoned]
@malfet
Update
7446612 
[ghstack-poisoned]
@malfet
Update
0474653 
[ghstack-poisoned]
This was referenced Oct 31, 2025
Closed
Closed
malfet added 2 commits October 31, 2025 13:59
@malfet
Update
da2e67f 
[ghstack-poisoned]
@malfet
Update
5adb0bd 
[ghstack-poisoned]
@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Oct 31, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 31, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Nov 3, 2025

@pytorchbot revert -c nosignal -m "sorry need to revert #166687"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 3, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 3, 2025

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 3, 2025
@pytorchmergebot
Revert "[MPS] Error out when BatchNorm is called for Complex (#166215)"
a4077b5 
This reverts commit 9261a1f.

Reverted #166215 on behalf of https://github.com/atalman due to sorry need to revert #166687 ([comment](#166215 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 3, 2025
@malfet
Update
3dfb374 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Nov 3, 2025
@malfet
[MPS] Error out when BatchNorm is called for Complex
eafc823 
Or Long types

Discovered while trying to enable `test_ops.py` for MPS

ghstack-source-id: 4789eb9
Pull Request resolved: #166215
@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Nov 3, 2025

@pytorchbot merge -f "This should just work"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 3, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@malfet @etaf
[MPS] Error out when BatchNorm is called for Complex (pytorch#166215)
3bdef3d 
Or BatchNorm or LayerNorm for Long types

Discovered while trying to enable `test_ops.py` for MPS
Pull Request resolved: pytorch#166215
Approved by: https://github.com/dcci, https://github.com/kulinseth, https://github.com/Skylion007
ghstack dependencies: pytorch#166214, pytorch#166687
pytorch-bot Bot pushed a commit that referenced this pull request Nov 4, 2025
@pytorchmergebot @etaf
Revert "[MPS] Error out when BatchNorm is called for Complex (#166215)"
ddd72e6 
This reverts commit 9261a1f.

Reverted #166215 on behalf of https://github.com/atalman due to sorry need to revert #166687 ([comment](#166215 (comment)))
pytorch-bot Bot pushed a commit that referenced this pull request Nov 4, 2025
@malfet @etaf
[MPS] Error out when BatchNorm is called for Complex (#166215)
6fa82f1 
Or BatchNorm or LayerNorm for Long types

Discovered while trying to enable `test_ops.py` for MPS
Pull Request resolved: #166215
Approved by: https://github.com/dcci, https://github.com/kulinseth, https://github.com/Skylion007
ghstack dependencies: #166214
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@malfet
[MPS] Error out when BatchNorm is called for Complex
613a861 
Or Long types

Discovered while trying to enable `test_ops.py` for MPS

ghstack-source-id: d16fc08
Pull Request resolved: pytorch/pytorch#166215
@github-actions github-actions Bot deleted the gh/malfet/572/head branch December 4, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@dcci dcci dcci approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category Reverted topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @pytorchmergebot @atalman @kulinseth @Skylion007 @dcci