[dynamo] Replace tx.inline_user_function_return with call_function#166007
Closed
anijain2305 wants to merge 2 commits intogh/anijain2305/922/basefrom
Closed
[dynamo] Replace tx.inline_user_function_return with call_function#166007anijain2305 wants to merge 2 commits intogh/anijain2305/922/basefrom
anijain2305 wants to merge 2 commits intogh/anijain2305/922/basefrom
Conversation
tx.inline_user_function_return only works for UserDefinedFunction, but as we use more VariableTracker build, we should use call_function. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166007
Note: Links to docs will display an error until the docs builds have been completed. ❌ 19 New FailuresAs of commit 5f81117 with merge base 8daef35 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
This PR needs a
|
…function" tx.inline_user_function_return only works for UserDefinedFunction, but as we use more VariableTracker build, we should use call_function. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
tx.inline_user_function_return only works for UserDefinedFunction, but
as we use more VariableTracker build, we should use call_function.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo @chenyang78