[DeviceMesh] Clean up the call into mesh_resouces to get root mesh#165787
Closed
fduwjj wants to merge 4 commits intogh/fduwjj/227/basefrom
Closed
[DeviceMesh] Clean up the call into mesh_resouces to get root mesh#165787fduwjj wants to merge 4 commits intogh/fduwjj/227/basefrom
fduwjj wants to merge 4 commits intogh/fduwjj/227/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165787
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 8 New Failures, 1 Cancelled Job, 7 Unrelated FailuresAs of commit 47a12eb with merge base 61d9a51 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
We should definitely import this PR to the internal code base first. I vaguely remember some internal code base also uses the global variable. |
fegin
approved these changes
Oct 17, 2025
…oot mesh" We moved the method to get root mesh into class in #164510. This is to further clean code up. cc H-Huang awgu wanchaol fegin wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…oot mesh" We moved the method to get root mesh into class in #164510. This is to further clean code up. cc H-Huang awgu wanchaol fegin wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…oot mesh" We moved the method to get root mesh into class in #164510. This is to further clean code up. cc H-Huang awgu wanchaol fegin wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
Contributor
Author
|
@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
pytorchbot merge -i "failed test is not related, also no internal test failure. RCOM test can not be reproced" |
Contributor
Author
|
@pytorchbot merge -i "failed test is not related, also no internal test failure. RCOM test can not be reproced" |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…ytorch#165787) We moved the method to get root mesh into class in pytorch#164510. This is to further clean code up. Differential Revision: [D85090191](https://our.internmc.facebook.com/intern/diff/D85090191) Pull Request resolved: pytorch#165787 Approved by: https://github.com/fegin
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…ytorch#165787) We moved the method to get root mesh into class in pytorch#164510. This is to further clean code up. Differential Revision: [D85090191](https://our.internmc.facebook.com/intern/diff/D85090191) Pull Request resolved: pytorch#165787 Approved by: https://github.com/fegin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We moved the method to get root mesh into class in #164510. This is to further clean code up.
cc @H-Huang @awgu @wanchaol @fegin @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci
Differential Revision: D85090191