Skip to content

Change forkserver test to only run below 3.13.8#165667

Closed
yushangdi wants to merge 1 commit intomainfrom
forkserver_fix
Closed

Change forkserver test to only run below 3.13.8#165667
yushangdi wants to merge 1 commit intomainfrom
forkserver_fix

Conversation

@yushangdi
Copy link
Contributor

A multiprocessing bug is fixed in 3.13.8, see https://docs.python.org/3.13/whatsnew/changelog.html, gh-126631

So this test will fail when we update to python 3.13.8

@yushangdi yushangdi requested a review from lijia19 October 16, 2025 19:00
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165667

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 25 Pending

As of commit ba5b310 with merge base 13b621d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 16, 2025
@yushangdi yushangdi requested review from d4l3k and malfet October 16, 2025 19:00
@yushangdi yushangdi mentioned this pull request Oct 16, 2025
@lijia19 lijia19 closed this Oct 16, 2025
@yushangdi yushangdi reopened this Oct 16, 2025
@malfet
Copy link
Contributor

malfet commented Oct 16, 2025

@pytorchbot merge -f "Lint/CI was green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yushangdi added a commit that referenced this pull request Oct 16, 2025
Add mingw to `pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11` docker image to support AOTI cross-compilation

This PR will make docker container rebuild, and upgrade python version from 3.13.7 to 3.13.8. and it relies on #165667

[ghstack-poisoned]
yushangdi added a commit that referenced this pull request Oct 16, 2025
Add mingw to `pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11` docker image to support AOTI cross-compilation

This PR will make docker container rebuild, and upgrade python version from 3.13.7 to 3.13.8. and it relies on #165667

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Oct 17, 2025
Add mingw to `pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11` docker image to support AOTI cross-compilation

This PR will make docker container rebuild, and upgrade python version from 3.13.7 to 3.13.8. and it relies on #165667
Pull Request resolved: #165560
Approved by: https://github.com/malfet
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Add mingw to `pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11` docker image to support AOTI cross-compilation

This PR will make docker container rebuild, and upgrade python version from 3.13.7 to 3.13.8. and it relies on pytorch#165667
Pull Request resolved: pytorch#165560
Approved by: https://github.com/malfet
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
Add mingw to `pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11` docker image to support AOTI cross-compilation

This PR will make docker container rebuild, and upgrade python version from 3.13.7 to 3.13.8. and it relies on pytorch#165667
Pull Request resolved: pytorch#165560
Approved by: https://github.com/malfet
@atalman
Copy link
Contributor

atalman commented Nov 7, 2025

@pytorchbot cherry-pick --onto release/2.9 --fixes "CI regression" -c regression

@pytorchbot
Copy link
Collaborator

Cherry picking #165667

The cherry pick PR is at #167361 and it is linked with issue CI regression. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Nov 7, 2025
@github-actions github-actions bot deleted the forkserver_fix branch December 8, 2025 02:19
@Flamefire
Copy link
Collaborator

We see this failing on Python 3.12.3:
Actual time is 7.409316015000513 against expected time of 4*5=20

Was this tested on Python 3.12 at some point? It seems the patch was not backported to 3.12.3 but maybe the bug didn't exist there in the first place or something else is in effect here caching the creation of the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants