Skip to content

Repro for property related Dynamo graph break#165609

Closed
ezyang wants to merge 3 commits intogh/ezyang/3176/basefrom
gh/ezyang/3176/head
Closed

Repro for property related Dynamo graph break#165609
ezyang wants to merge 3 commits intogh/ezyang/3176/basefrom
gh/ezyang/3176/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 16, 2025 •
edited
Loading

@ezyang
Update
7a3d89d 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165609

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e8d428c with merge base 5eddbb5 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 16, 2025
@ezyang
Repro for property related Dynamo graph break
bfba7aa 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 38a7424
Pull-Request: #165609
@ezyang ezyang mentioned this pull request Oct 16, 2025
Closed
@ezyang
Update
2efe8fb 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 16, 2025
@ezyang
Repro for property related Dynamo graph break
e91aa46 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 4a88c7d
Pull-Request: #165609
ezyang
ezyang commented Oct 16, 2025
View reviewed changes
test/dynamo/test_functions.py
def __call__(self):
return True

p = property(PropertyGetter())
Copy link
Contributor Author

@ezyang ezyang Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is specifically that we have a non-function thing as a method on the class

@ezyang ezyang requested a review from anijain2305 October 16, 2025 04:01
@ezyang
Update
e8d428c 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 16, 2025
@ezyang
Repro for property related Dynamo graph break
1e285e8 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: bb85fac
Pull-Request: #165609
albanD
albanD approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ezyang
Copy link
Contributor Author

ezyang commented Oct 16, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ruomingp
Copy link

ruomingp commented Oct 16, 2025

Thanks! Is there an issue to track the support for partials and callable class instances, if one is planned?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 16, 2025

Thanks! Is there an issue to track the support for partials and callable class instances, if one is planned?

Not yet but they should all get fixed as well @anijain2305

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@ezyang @Chao1Han
Repro for property related Dynamo graph break (pytorch#165609)
29ae197 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#165609
Approved by: https://github.com/albanD, https://github.com/gchanan, https://github.com/malfet, https://github.com/anijain2305
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@ezyang @zhudada0120
Repro for property related Dynamo graph break (pytorch#165609)
7c6cc8c 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#165609
Approved by: https://github.com/albanD, https://github.com/gchanan, https://github.com/malfet, https://github.com/anijain2305
@github-actions github-actions bot deleted the gh/ezyang/3176/head branch November 16, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@gchanan gchanan gchanan approved these changes

@albanD albanD albanD approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ezyang @pytorchmergebot @ruomingp @malfet @gchanan @albanD @anijain2305