12/n : Remove fbandroid_compiler_flags#165558
12/n : Remove fbandroid_compiler_flags#165558kambati-meta wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: Currently `get_c2_fbandroid_xplat_compiler_flags()` is reading the `caffe2.strip_glog` buckconfig which we want to get rid of. This diff removes the `fbandroid_compiler_flags` arg and merges it with compiler_flags with a nested select and the select version of the method The goal is to get rid of all the usages of `get_c2_fbandroid_xplat_compiler_flags()` so that we can get rid of the `caffe2.strip_glog` buckconfig Test Plan: CI Differential Revision: D84626885
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @kambati-meta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165558
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit a558d5b with merge base 815d641 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@kambati-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84626885. |
|
❌ 🤖 pytorchbot command failed: |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit d7ffa8b. Reverted #165558 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#165558 (comment)))
|
@kambati-meta your PR has been successfully reverted. |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f 'already merged internally' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m="Diff was actually reverted internally D84832629" -c="ghfirst" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit aead927. Reverted #165558 on behalf of https://github.com/clee2000 due to Diff was actually reverted internally D84832629 ([comment](#165558 (comment)))
|
@kambati-meta your PR has been successfully reverted. |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
This reverts commit aead927. Reverted pytorch#165558 on behalf of https://github.com/clee2000 due to Diff was actually reverted internally D84832629 ([comment](pytorch#165558 (comment)))
Summary: Currently `get_c2_fbandroid_xplat_compiler_flags()` is reading the `caffe2.strip_glog` buckconfig which we want to get rid of. This diff removes the `fbandroid_compiler_flags` arg and merges it with compiler_flags with a nested select and the select version of the method The goal is to get rid of all the usages of `get_c2_fbandroid_xplat_compiler_flags()` so that we can get rid of the `caffe2.strip_glog` buckconfig Test Plan: CI Differential Revision: D84626885 Pull Request resolved: pytorch#165558 Approved by: https://github.com/malfet
This reverts commit d7ffa8b. Reverted pytorch#165558 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#165558 (comment)))
Summary: Currently `get_c2_fbandroid_xplat_compiler_flags()` is reading the `caffe2.strip_glog` buckconfig which we want to get rid of. This diff removes the `fbandroid_compiler_flags` arg and merges it with compiler_flags with a nested select and the select version of the method The goal is to get rid of all the usages of `get_c2_fbandroid_xplat_compiler_flags()` so that we can get rid of the `caffe2.strip_glog` buckconfig Test Plan: CI bifferential Revision: D84626885 Pull Request resolved: pytorch#165558 Approved by: https://github.com/malfet
This reverts commit aead927. Reverted pytorch#165558 on behalf of https://github.com/clee2000 due to Diff was actually reverted internally D84832629 ([comment](pytorch#165558 (comment)))
This reverts commit d7ffa8b. Reverted pytorch#165558 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#165558 (comment)))
Summary: Currently `get_c2_fbandroid_xplat_compiler_flags()` is reading the `caffe2.strip_glog` buckconfig which we want to get rid of. This diff removes the `fbandroid_compiler_flags` arg and merges it with compiler_flags with a nested select and the select version of the method The goal is to get rid of all the usages of `get_c2_fbandroid_xplat_compiler_flags()` so that we can get rid of the `caffe2.strip_glog` buckconfig Test Plan: CI bifferential Revision: D84626885 Pull Request resolved: pytorch#165558 Approved by: https://github.com/malfet
This reverts commit aead927. Reverted pytorch#165558 on behalf of https://github.com/clee2000 due to Diff was actually reverted internally D84832629 ([comment](pytorch#165558 (comment)))
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
Currently
get_c2_fbandroid_xplat_compiler_flags()is reading thecaffe2.strip_glogbuckconfig which we want to get rid of.This diff removes the
fbandroid_compiler_flagsarg and merges it with compiler_flags with a nested select and the select version of the methodThe goal is to get rid of all the usages of
get_c2_fbandroid_xplat_compiler_flags()so that we can get rid of thecaffe2.strip_glogbuckconfigTest Plan: CI
Differential Revision: D84626885