Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165515
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 242f86d with merge base b11593c ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
c0aeac8 to
e905ce0
Compare
e905ce0 to
a807420
Compare
a807420 to
23ea544
Compare
23ea544 to
1a92d38
Compare
1a92d38 to
bf755f8
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
bf755f8 to
242f86d
Compare
Lucaskabela
left a comment
There was a problem hiding this comment.
Trying to get to the source of this CI failure that I personally have never seen before - let's add a snippet of running the mentioned file to check/derisk
| import requests | ||
|
|
||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
I am a tad concerned the red CI signal related to nightly means there is some function in here that we have broken - do we have a unit test or can you include an example of running a function from this file using the Callable annotation to derisk? Thanks!
There was a problem hiding this comment.
Callable is used for static type checking in upload_stats_lib.py because the change imports it under TYPE_CHECKING so it is not responsible for the red CI.
The red CI is likely a flaky test being triggered. Let's wait for some time for verification.
There was a problem hiding this comment.
The CI failures are now marked as flaky.
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: Nightly Upload to s3 / upload-stats-to-s3, inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: This is follow-up of #165214 to continue applying ruff UP035 rule to the code base. X-link: pytorch/pytorch#165515 Approved by: https://github.com/Lucaskabela Reviewed By: seemethere Differential Revision: D84890963 fbshipit-source-id: 49b04017014b510b9903e79d5d98af0da8d74b32
This is follow-up of pytorch#165214 to continue applying ruff UP035 rule to the code base. Pull Request resolved: pytorch#165515 Approved by: https://github.com/Lucaskabela
This is follow-up of pytorch#165214 to continue applying ruff UP035 rule to the code base. Pull Request resolved: pytorch#165515 Approved by: https://github.com/Lucaskabela
This is a follow-up of #165515. ruff `UP035` rules are applied to dynamo code to use Py 3.10+ typing. Pull Request resolved: #165709 Approved by: https://github.com/ezyang
This is follow-up of #165214 to continue applying ruff UP035 rule to the code base.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela @xmfan