[user-events] Add inductor event types#165390
Closed
mlazos wants to merge 10 commits intogh/mlazos/41/basefrom
Closed
[user-events] Add inductor event types#165390mlazos wants to merge 10 commits intogh/mlazos/41/basefrom
mlazos wants to merge 10 commits intogh/mlazos/41/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165390
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit c0ad8c3 with merge base 63776ec ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 14, 2025
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
This was referenced Jan 21, 2026
suncapitalllc007-star
pushed a commit
to suncapitalllc007-star/pytorch
that referenced
this pull request
Jan 25, 2026
ghstack-source-id: a7a6c7d Pull Request resolved: pytorch/pytorch#165390
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
eellison
approved these changes
Feb 24, 2026
Contributor
eellison
left a comment
There was a problem hiding this comment.
a lil hard to review without tests but i understand we're breaking it up..
torch/_inductor/event.py
Outdated
| """Initialize a event factory.""" | ||
| self.symbolic_event_idx: itertools.count = itertools.count(start=1) | ||
| self.materialized_event_idx: itertools.count = itertools.count(start=1) | ||
| self.available_materialized_events: OrderedSet[str] = OrderedSet() |
Contributor
There was a problem hiding this comment.
any reason to not just make these the actual event objects, and not strings ?
torch/_inductor/event.py
Outdated
| code.writeline(f"{event} = torch.cuda.Event()") | ||
| return event | ||
|
|
||
| def deposit_materialized_event(self, event: str) -> None: |
Contributor
There was a problem hiding this comment.
Would it make sense to give event a different type than string, with a default repr?
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #165391 |
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo chenyang78 [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #165391 |
2 similar comments
Collaborator
|
Starting merge as part of PR stack under #165391 |
Collaborator
|
Starting merge as part of PR stack under #165391 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 5, 2026
This PR adds utility functions for managing streams and a stream pool. Pull Request resolved: #165504 Approved by: https://github.com/eellison ghstack dependencies: #165390
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 5, 2026
This PR implements stream codegen to the SubgraphWrapper Codegen. It supports codegen for enter/exiting stream contexts and calling record_stream on returned tensors. Pull Request resolved: #165391 Approved by: https://github.com/eellison ghstack dependencies: #165390, #165504
Vighaneshs
pushed a commit
to Vighaneshs/pytorch
that referenced
this pull request
Mar 5, 2026
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events. Pull Request resolved: pytorch#165390 Approved by: https://github.com/eellison
Vighaneshs
pushed a commit
to Vighaneshs/pytorch
that referenced
this pull request
Mar 5, 2026
This PR adds utility functions for managing streams and a stream pool. Pull Request resolved: pytorch#165504 Approved by: https://github.com/eellison ghstack dependencies: pytorch#165390
Vighaneshs
pushed a commit
to Vighaneshs/pytorch
that referenced
this pull request
Mar 5, 2026
…h#165391) This PR implements stream codegen to the SubgraphWrapper Codegen. It supports codegen for enter/exiting stream contexts and calling record_stream on returned tensors. Pull Request resolved: pytorch#165391 Approved by: https://github.com/eellison ghstack dependencies: pytorch#165390, pytorch#165504
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
ghstack-source-id: beed124 Pull Request resolved: pytorch/pytorch#165390
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
ghstack-source-id: 0790e88 Pull Request resolved: pytorch/pytorch#165390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Symbolic events in the TorchInductor scheduler. In short, we create an EventFactory which provides event indices which monotonically increase as compile proceeds and enables reuse of events that are no longer used. It also adds codegen support for events.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @chenyang78