make aotdispatcher opinfo tests keep input mutations in graph#165327
Closed
bdhirsh wants to merge 4 commits intogh/bdhirsh/673/basefrom
Closed
make aotdispatcher opinfo tests keep input mutations in graph#165327bdhirsh wants to merge 4 commits intogh/bdhirsh/673/basefrom
bdhirsh wants to merge 4 commits intogh/bdhirsh/673/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165327
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 28ca15d with merge base 74db92b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…aph" [ghstack-poisoned]
…aph" This stack is going to turn off functionalization and turn on the default partitioner, so I'm going to separate out a few changes before turning off functionalization in our OpInfo tests: (1) run our tests with input mutations allowed inside the graph (2) run our tests with the default partitioner (3) run with functionalization off (4) (later) make the tests properly test for bitwise equivalence [ghstack-poisoned]
…aph" This stack is going to turn off functionalization and turn on the default partitioner, so I'm going to separate out a few changes before turning off functionalization in our OpInfo tests: (1) run our tests with input mutations allowed inside the graph (2) run our tests with the default partitioner (3) run with functionalization off (4) (later) make the tests properly test for bitwise equivalence [ghstack-poisoned]
ezyang
approved these changes
Oct 14, 2025
Collaborator
|
Starting merge as part of PR stack under #165372 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 14, 2025
I noticed the default partitioner was breaking in some dynamic shape tests, so prior to turning off functionalization I want to tweak it to pass all of our OpInfo tests Pull Request resolved: #165372 Approved by: https://github.com/ezyang ghstack dependencies: #165327
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 15, 2025
…h#165327) This stack is going to turn off functionalization and turn on the default partitioner, so I'm going to separate out a few changes before turning off functionalization in our OpInfo tests: (1) run our tests with input mutations allowed inside the graph (2) run our tests with the default partitioner (3) run with functionalization off (4) (later) make the tests properly test for bitwise equivalence Pull Request resolved: pytorch#165327 Approved by: https://github.com/ezyang
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 15, 2025
I noticed the default partitioner was breaking in some dynamic shape tests, so prior to turning off functionalization I want to tweak it to pass all of our OpInfo tests Pull Request resolved: pytorch#165372 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#165327
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…h#165327) This stack is going to turn off functionalization and turn on the default partitioner, so I'm going to separate out a few changes before turning off functionalization in our OpInfo tests: (1) run our tests with input mutations allowed inside the graph (2) run our tests with the default partitioner (3) run with functionalization off (4) (later) make the tests properly test for bitwise equivalence Pull Request resolved: pytorch#165327 Approved by: https://github.com/ezyang
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
I noticed the default partitioner was breaking in some dynamic shape tests, so prior to turning off functionalization I want to tweak it to pass all of our OpInfo tests Pull Request resolved: pytorch#165372 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#165327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stack is going to turn off functionalization and turn on the default partitioner, so I'm going to separate out a few changes before turning off functionalization in our OpInfo tests:
(1) run our tests with input mutations allowed inside the graph
(2) run our tests with the default partitioner
(3) run with functionalization off
(4) (later) make the tests properly test for bitwise equivalence
Stack from ghstack (oldest at bottom):