Widen ops support to take in IntHOArrayRef vs only std::vec by janeyx99 · Pull Request #165152 · pytorch/pytorch

janeyx99 · 2025-10-10T16:02:46Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-10-10T16:02:50Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165152

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit fcf6011 with merge base d7e2d0a ():

NEW FAILURE - The following job has failed:

trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
test_ops

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (similar failure)
RuntimeError: doctests 1/1 failed!

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
test/test_torchfuzz_repros.py::TestFuzzerCompileIssues::test_fuzzer_issue_163971

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) (gh) (#166072)
examples/models/llama/tests/test_export_llama_lib.py::ExportLlamaLibTest::test_has_expected_ops_and_op_counts

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

mikaylagawarecki · 2025-10-14T17:30:31Z

  std::string mode = "constant";
  double value = 0.0;
-  return pad(t, padding, mode, value);
+  return pad(t, {1, 2, 2, 1}, mode, value);


n00b q for my understanding: since ArrayRef does not own the underlying data what keeps the initializer list alive

this function local scope, i believe

[ghstack-poisoned]

janeyx99 · 2025-10-16T20:14:39Z

@pytorchbot merge

pytorchmergebot · 2025-10-16T20:16:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-16T23:43:15Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team

Raised by workflow job

janeyx99 · 2025-10-17T18:24:15Z

@pytorchbot merge -i

pytorchmergebot · 2025-10-17T18:26:22Z

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable), trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…165152)" This reverts commit e445494. Reverted #165152 on behalf of https://github.com/clee2000 due to breaking internal tests D84961075 ([comment](#164991 (comment)))

pytorchmergebot · 2025-10-20T17:26:45Z

@janeyx99 your PR has been reverted as part of the stack under #164991.

[ghstack-poisoned]

…165152) Pull Request resolved: pytorch#165152 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164991

…ytorch#165152)" This reverts commit e445494. Reverted pytorch#165152 on behalf of https://github.com/clee2000 due to breaking internal tests D84961075 ([comment](pytorch#164991 (comment)))

…165152) Pull Request resolved: pytorch#165152 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164991

…ytorch#165152)" This reverts commit e445494. Reverted pytorch#165152 on behalf of https://github.com/clee2000 due to breaking internal tests D84961075 ([comment](pytorch#164991 (comment)))

[ghstack-poisoned]

janeyx99 · 2025-11-04T23:43:55Z

@pytorchbot merge

pytorchmergebot · 2025-11-04T23:45:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-11-05T03:30:24Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

janeyx99 · 2025-11-05T15:57:42Z

@pytorchbot merge -f "Failures have been on trunk"

pytorchmergebot · 2025-11-05T15:59:48Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #165153 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: #164991, #165152

Some important notes: a) Just like IValues steal the ownership of ArrayRefs and any std::vectors in order to convert the inner elements into IValues, we do the same thing with StableIValue. This O(N) traverse is ineluctable. b) As a result, since StableIValues are owning and our contract is that to<T>(StableIValue) transfers ownership, you cannot ever convert from StableIValue to a nonowning HeaderOnlyArrayRef<V>. We handle memory similar to AtenTensorHandle, but we have a StableListHandle! Pull Request resolved: #165953 Approved by: https://github.com/malfet ghstack dependencies: #164991, #165152, #165153

Pull Request resolved: #167126 Approved by: https://github.com/Skylion007 ghstack dependencies: #164991, #165152, #165153, #165953

ghstack-source-id: 45e476c Pull Request resolved: pytorch/pytorch#165152

Some important notes: a) Just like IValues steal the ownership of ArrayRefs and any std::vectors in order to convert the inner elements into IValues, we do the same thing with StableIValue. This O(N) traverse is ineluctable. b) As a result, since StableIValues are owning and our contract is that to<T>(StableIValue) transfers ownership, you cannot ever convert from StableIValue to a nonowning HeaderOnlyArrayRef<V>. We handle memory similar to AtenTensorHandle, but we have a StableListHandle! Pull Request resolved: pytorch#165953 Approved by: https://github.com/malfet ghstack dependencies: pytorch#164991, pytorch#165152, pytorch#165153

) Pull Request resolved: pytorch#167126 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#164991, pytorch#165152, pytorch#165153, pytorch#165953

Widen ops support to take in IntHOArrayRef vs only std::vec

3b93666

[ghstack-poisoned]

janeyx99 requested a review from mikaylagawarecki as a code owner October 10, 2025 16:02

This was referenced Oct 10, 2025

Refactor out headeronly ArrayRef #164991

Closed

Add torch::stable::Tensor sizes and strides #165153

Closed

Update on "Widen ops support to take in IntHOArrayRef vs only std::vec"

f6cabee

[ghstack-poisoned]

mikaylagawarecki approved these changes Oct 14, 2025

View reviewed changes

janeyx99 added 2 commits October 14, 2025 11:30

Update on "Widen ops support to take in IntHOArrayRef vs only std::vec"

38c85f0

[ghstack-poisoned]

Update on "Widen ops support to take in IntHOArrayRef vs only std::vec"

809b28d

[ghstack-poisoned]

janeyx99 added the release notes: cpp release notes category label Oct 16, 2025

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2025

pytorchmergebot added the merging label Oct 16, 2025

pytorchmergebot removed the merging label Oct 16, 2025

pytorchmergebot added the merging label Oct 17, 2025

pytorchmergebot added the Merged label Oct 17, 2025

pytorchmergebot closed this in e445494 Oct 17, 2025

pytorchmergebot removed the merging label Oct 17, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 20, 2025

pytorchmergebot reopened this Oct 20, 2025

Update on "Widen ops support to take in IntHOArrayRef vs only std::vec"

6cc7aad

[ghstack-poisoned]

janeyx99 mentioned this pull request Oct 21, 2025

Introducing the StableIValue representation of list :D #165953

Closed

Update on "Widen ops support to take in IntHOArrayRef vs only std::vec"

fcf6011

[ghstack-poisoned]

pytorchmergebot added the merging label Nov 4, 2025

pytorchmergebot removed the merging label Nov 5, 2025

pytorchmergebot added the merging label Nov 5, 2025

pytorchmergebot closed this in 7a6ff88 Nov 5, 2025

pytorchmergebot removed the merging label Nov 5, 2025

pytorchmergebot pushed a commit that referenced this pull request Nov 5, 2025

Add torch::stable::Tensor sizes and strides (#165153)

c6c913d

Pull Request resolved: #165153 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: #164991, #165152

janeyx99 mentioned this pull request Nov 5, 2025

[BE] use undeprecated from/to in libtorch_agnostic tests #167126

Closed

pytorchmergebot pushed a commit that referenced this pull request Nov 7, 2025

[BE] use undeprecated from/to in libtorch_agnostic tests (#167126)

46516ef

Pull Request resolved: #167126 Approved by: https://github.com/Skylion007 ghstack dependencies: #164991, #165152, #165153, #165953

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025

Widen ops support to take in IntHOArrayRef vs only std::vec

a006c00

ghstack-source-id: 45e476c Pull Request resolved: pytorch/pytorch#165152

github-actions Bot deleted the gh/janeyx99/315/head branch December 6, 2025 02:15

Conversation

janeyx99 commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165152

❌ 1 New Failure, 3 Unrelated Failures

Uh oh!

mikaylagawarecki Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

janeyx99 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

janeyx99 commented Oct 16, 2025

Uh oh!

pytorchmergebot commented Oct 16, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 16, 2025

Merge failed

Uh oh!

janeyx99 commented Oct 17, 2025

Uh oh!

pytorchmergebot commented Oct 17, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 20, 2025

Uh oh!

janeyx99 commented Nov 4, 2025

Uh oh!

pytorchmergebot commented Nov 4, 2025

Merge started

Uh oh!

pytorchmergebot commented Nov 5, 2025

Merge failed

Uh oh!

janeyx99 commented Nov 5, 2025

Uh oh!

pytorchmergebot commented Nov 5, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

janeyx99 commented Oct 10, 2025 •

edited

Loading

pytorch-bot Bot commented Oct 10, 2025 •

edited

Loading