Skip to content

[ATen] Add reduction tag to reduction operators#165146

Closed
eellison wants to merge 1 commit intogh/eellison/847/basefrom
gh/eellison/847/head
Closed

[ATen] Add reduction tag to reduction operators#165146
eellison wants to merge 1 commit intogh/eellison/847/basefrom
gh/eellison/847/head

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Oct 10, 2025

Stack from ghstack (oldest at bottom):

Add a new 'reduction' tag to tags.yaml and apply it to 98 reduction
operator variants across 21 operator families (sum, mean, min, max,
argmin, argmax, amin, amax, aminmax, prod, all, any, norm, var, std,
std_mean, var_mean, nansum, logsumexp, count_nonzero, linalg_vector_norm).

This tag categorizes operators that perform reduction operations,
computing aggregate values across one or more dimensions of input
tensor(s).

Based on PR #153342 - co-written with @AlonSardas.

Just as we have pointwise tag - this can be useful for compiler passes, or for opting into sharding rules.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165146

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 42 Pending

As of commit 0283f13 with merge base 6d27a8e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Oct 10, 2025
    Add a new 'reduction' tag to tags.yaml and apply it to 98 reduction
    operator variants across 21 operator families (sum, mean, min, max,
    argmin, argmax, amin, amax, aminmax, prod, all, any, norm, var, std,
    std_mean, var_mean, nansum, logsumexp, count_nonzero, linalg_vector_norm).

    This tag categorizes operators that perform reduction operations,
    computing aggregate values across one or more dimensions of input
    tensor(s).

    Based on PR #153342

ghstack-source-id: 6c9c42f
Pull Request resolved: #165146
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@eellison eellison requested review from bdhirsh and zou3519 October 10, 2025 16:26
@eellison eellison closed this Oct 10, 2025
@github-actions github-actions bot deleted the gh/eellison/847/head branch November 10, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant