Add clang-tidy misc-definitions-in-headers check#164959
Add clang-tidy misc-definitions-in-headers check#164959janeyx99 wants to merge 2 commits intogh/janeyx99/313/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164959
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 294ab31 with merge base ab82456 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| InheritParentConfig: true | ||
| Checks: ' | ||
| google-global-names-in-headers, | ||
| misc-definitions-in-headers, |
There was a problem hiding this comment.
Pretty sure this clang-tidy check does nothing unless any compilation targets on in the folder, but go ahead.
There was a problem hiding this comment.
haha when I develop it shows underlines, which is better than not having underlines
There was a problem hiding this comment.
yea I think it's good to add, and I'll test if turning on warnings-as-errors does anything in CI in #164963
|
@pytorchbot merge -r I'm merging this stack to get our from/to out of the global namespace asap. There is still ongoing discussion about inline vs anon namespaces, and I'll take responsibility in correcting the files if needed. |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: pytorch#164959 Approved by: https://github.com/Skylion007, https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164882, pytorch#164956
Pull Request resolved: pytorch#164959 Approved by: https://github.com/Skylion007, https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164882, pytorch#164956
Stack from ghstack (oldest at bottom):