Use PyObject_GetOptionalAttrString in PyObject_FastGetAttrString when available#164624
Closed
swolchok wants to merge 1 commit intogh/swolchok/850/basefrom
Closed
Use PyObject_GetOptionalAttrString in PyObject_FastGetAttrString when available#164624swolchok wants to merge 1 commit intogh/swolchok/850/basefrom
swolchok wants to merge 1 commit intogh/swolchok/850/basefrom
Conversation
… available Python 3.13 added PyObject_GetOptionalAttrString. I'm not 100% certain that it is strictly better than the old approach in all cases, but based on documentation/comments it seems to be meant for this type of use, and it's faster when I profile torchtitan training (which gets to checking for the __torch_function__ attr on some object frequently enough to notice, but wastes a bunch of time generating exceptions that we then suppressed here). [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164624
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ae716fc with merge base bf717ce ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Oct 4, 2025
|
|
||
| inline py::object PyObject_FastGetAttrString(PyObject* obj, const char* name) { | ||
| #if IS_PYTHON_3_13_PLUS | ||
| PyObject* res = (PyObject*)nullptr; |
Collaborator
There was a problem hiding this comment.
Huh, so the cast from nulptr necessary? Probably a holdover from C to C++ copy paste but probably better to save for a file wide cleanup
Contributor
Author
There was a problem hiding this comment.
not sure, but didn't want to wait a full CI round-trip just to find out the old one was there for good reason
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 21, 2025
…164625) Pybind's API entails a small unnecessary overhead when working with args. (Similarly, we should probably be using vectorcall, but that's a bigger change for both us and pybind11.) Pull Request resolved: #164625 Approved by: https://github.com/albanD ghstack dependencies: #164624
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
… available (pytorch#164624) Python 3.13 added PyObject_GetOptionalAttrString. I'm not 100% certain that it is strictly better than the old approach in all cases, but based on documentation/comments it seems to be meant for this type of use, and it's faster when I profile torchtitan training (which gets to the "check for the `__torch_function__` attr on some object" part of maybe_has_torch_function frequently enough to notice, but wastes a bunch of time generating exceptions that we then suppressed here). Pull Request resolved: pytorch#164624 Approved by: https://github.com/Skylion007
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…ytorch#164625) Pybind's API entails a small unnecessary overhead when working with args. (Similarly, we should probably be using vectorcall, but that's a bigger change for both us and pybind11.) Pull Request resolved: pytorch#164625 Approved by: https://github.com/albanD ghstack dependencies: pytorch#164624
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…ytorch#164625) Pybind's API entails a small unnecessary overhead when working with args. (Similarly, we should probably be using vectorcall, but that's a bigger change for both us and pybind11.) Pull Request resolved: pytorch#164625 Approved by: https://github.com/albanD ghstack dependencies: pytorch#164624
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
… available Python 3.13 added PyObject_GetOptionalAttrString. I'm not 100% certain that it is strictly better than the old approach in all cases, but based on documentation/comments it seems to be meant for this type of use, and it's faster when I profile torchtitan training (which gets to checking for the __torch_function__ attr on some object frequently enough to notice, but wastes a bunch of time generating exceptions that we then suppressed here). ghstack-source-id: 2215645 Pull Request resolved: pytorch/pytorch#164624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Python 3.13 added PyObject_GetOptionalAttrString. I'm not 100% certain that it is strictly better than the old approach in all cases, but based on documentation/comments it seems to be meant for this type of use, and it's faster when I profile torchtitan training (which gets to the "check for the
__torch_function__attr on some object" part of maybe_has_torch_function frequently enough to notice, but wastes a bunch of time generating exceptions that we then suppressed here).