[BE][cutlass backend] BE changes post cutlass_cppgen name change#164589
Closed
henrylhtsang wants to merge 1 commit intopytorch:mainfrom
Closed
[BE][cutlass backend] BE changes post cutlass_cppgen name change#164589henrylhtsang wants to merge 1 commit intopytorch:mainfrom
henrylhtsang wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164589
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e402c45 with merge base da49a57 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@henrylhtsang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83809105. |
Skylion007
reviewed
Oct 3, 2025
| shutil.move(cutlass_cppgen.CACHE_FILE, os.path.join(cache_dir(), filename)) | ||
| log.debug("Moved CUTLASS compiled cache file to %s", cache_dir()) | ||
| except OSError as e: | ||
| log.warning("Failed to move CUTLASS compiled cache file: %s", str(e)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.warning("Failed to move CUTLASS compiled cache file: %s", str(e)) | |
| log.warning("Failed to move CUTLASS compiled cache file: %s", e) |
'%s' does an implicit str cast anyway
85e9844 to
0de6f59
Compare
henrylhtsang
added a commit
to henrylhtsang/pytorch
that referenced
this pull request
Oct 3, 2025
…orch#164589) Summary: Pull Request resolved: pytorch#164589 Differential Revision: D83809105
Skylion007
reviewed
Oct 3, 2025
| offset = inductor_layout.offset | ||
|
|
||
| def is_static_int(number): | ||
| def is_static_int(number: object) -> bool: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def is_static_int(number: object) -> bool: | |
| def is_static_int(number: object) -> TypeIs[int | sympy.Integer]: |
Collaborator
There was a problem hiding this comment.
import from typing_extensions if not already imported
Contributor
Author
There was a problem hiding this comment.
actually I don't feel like I understand why we should return TypeIs
0de6f59 to
e925499
Compare
henrylhtsang
added a commit
to henrylhtsang/pytorch
that referenced
this pull request
Oct 3, 2025
…orch#164589) Summary: Pull Request resolved: pytorch#164589 Differential Revision: D83809105
…orch#164589) Summary: Pull Request resolved: pytorch#164589 Differential Revision: D83809105
e925499 to
e402c45
Compare
Skylion007
approved these changes
Oct 4, 2025
Contributor
Author
|
@pytorchbot merge |
1 similar comment
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…orch#164589) Differential Revision: D83809105 Handle reviews from pytorch#164159 Pull Request resolved: pytorch#164589 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D83809105
Handle reviews from #164159
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben