Skip to content

Use torch.testing.test_close instead of torch.testing.test_allclose#164539

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:test_removal
Closed

Use torch.testing.test_close instead of torch.testing.test_allclose#164539
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:test_removal

Conversation

@cyyever
Copy link
Copy Markdown
Collaborator

@cyyever cyyever commented Oct 3, 2025 •
edited
Loading

@cyyever cyyever requested a review from jerryzh168 as a code owner October 3, 2025 02:06
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Oct 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164539

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6ac301b with merge base eccf561 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added ciflow/inductor module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category topic: not user facing topic category labels Oct 3, 2025
@cyyever cyyever changed the title Use test_close instead of test_allclose Use torch.testing.test_close instead of torch.testing.test_allclose Oct 3, 2025
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 3, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@cyyever cyyever marked this pull request as draft October 3, 2025 08:31
@cyyever
Use test_close instead of test_allclose
6ac301b 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever marked this pull request as ready for review October 3, 2025 14:31
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the test_removal branch October 4, 2025 01:28
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
Use torch.testing.test_close instead of torch.testing.test_allclose (p…
8ab426a 
…ytorch#164539)

Because torch.testing.test_allclose is deprecated.

Pull Request resolved: pytorch#164539
Approved by: https://github.com/mlazos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlazos mlazos mlazos approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: quantization release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @mlazos @pytorchbot