Skip to content

remove unnecessary registration#164481

Closed
eellison wants to merge 2 commits intogh/eellison/835/basefrom
gh/eellison/835/head
Closed

remove unnecessary registration#164481
eellison wants to merge 2 commits intogh/eellison/835/basefrom
gh/eellison/835/head

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Oct 2, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

scaled_mm already had needs_exact_strides in its op registration. also added a test showing these strides are being respected.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@eellison
Update
648cb0b 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164481

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 72fde2f with merge base d4e4f70 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Oct 2, 2025
@eellison
remove unnecessary registration
01677ee 
ghstack-source-id: 4f60c39
Pull Request resolved: #164481
@eellison
Update
72fde2f 
[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 2, 2025
@eellison
remove unnecessary registration
426204d 
ghstack-source-id: 191892b
Pull Request resolved: #164481
@eellison eellison mentioned this pull request Oct 2, 2025
Open
drisspg
drisspg approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eellison eellison added the topic: not user facing topic category label Oct 2, 2025
@eellison
Copy link
Contributor Author

eellison commented Oct 2, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 3, 2025

This PR (#164481) was merged in 4691fe6 but it is still open, likely due to a Github bug, so mergebot is closing it manually. If you think this is a mistake, please feel free to reopen and contact Dev Infra.

pull bot pushed a commit to ais-developer/pytorch that referenced this pull request Oct 3, 2025
@eellison @pytorchmergebot
remove unnecessary registration (pytorch#164481)
4691fe6 
scaled_mm already had `needs_exact_strides` in its op registration. also added a test showing these strides are being respected.

Pull Request resolved: pytorch#164481
Approved by: https://github.com/drisspg, https://github.com/mlazos
jeffdaily added a commit to ROCm/pytorch that referenced this pull request Oct 3, 2025
@jeffdaily
forward fix pytorch#164481
3ef95f8 
PR pytorch#164481 added unit test test_scaled_mm_preserves_strides in test/inductor/test_fp8.py.
It was missing the adjustment for ROCm's F8 types on MI300.
@amdfaa amdfaa mentioned this pull request Oct 3, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 3, 2025
@jeffdaily @pytorchmergebot
forward fix #164481 (#164578)
5656d45 
PR #164481 added unit test test_scaled_mm_preserves_strides in test/inductor/test_fp8.py. It was missing the adjustment for ROCm's F8 types on MI300.

Pull Request resolved: #164578
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
@yangw-dev
Copy link
Contributor

yangw-dev commented Oct 3, 2025

it seems a rocm test start to fail after this pr

see:
https://hud.pytorch.org/pytorch/pytorch/commit/4691fe60700ac51a878775fd23a8f7c4548c6757#51853528524-box

2025-10-03T03:26:21.3422505Z FAILED [0.5430s] inductor/test_fp8.py::TestFP8Lowering::test_scaled_mm_preserves_strides - RuntimeError: CUDA error: HIPBLAS_STATUS_NOT_SUPPORTED when calling HIPBLAS_STATUS_NOT_SUPPORTED

seems related, about to revert this pr

@yangw-dev
Copy link
Contributor

yangw-dev commented Oct 3, 2025

@pytorchbot revert -c nosignal -m "failed test in trunk https://hud.pytorch.org/pytorch/pytorch/commit/4691fe60700ac51a878775fd23a8f7c4548c6757#51853528524-box"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 3, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 3, 2025

Reverting PR 164481 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 4691fe60700ac51a878775fd23a8f7c4548c6757 returned non-zero exit code 1

Auto-merging test/inductor/test_fp8.py
CONFLICT (content): Merge conflict in test/inductor/test_fp8.py
error: could not revert 4691fe60700... remove unnecessary registration (#164481)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@eellison @Chao1Han
remove unnecessary registration (pytorch#164481)
53a862b 
scaled_mm already had `needs_exact_strides` in its op registration. also added a test showing these strides are being respected.

Pull Request resolved: pytorch#164481
Approved by: https://github.com/drisspg, https://github.com/mlazos
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@jeffdaily @Chao1Han
forward fix pytorch#164481 (pytorch#164578)
1af738e 
PR pytorch#164481 added unit test test_scaled_mm_preserves_strides in test/inductor/test_fp8.py. It was missing the adjustment for ROCm's F8 types on MI300.

Pull Request resolved: pytorch#164578
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
@github-actions github-actions bot deleted the gh/eellison/835/head branch November 3, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlazos mlazos mlazos approved these changes

@drisspg drisspg drisspg approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eellison @pytorchmergebot @yangw-dev @mlazos @drisspg