Skip to content

[6/N] Apply ruff UP035 rule#164438

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruff_035_7
Closed

[6/N] Apply ruff UP035 rule#164438
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruff_035_7

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 2, 2025

Continued code migration to enable ruff UP035. Most changes are about moving Callable from typing to from collections.abc.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @ezyang

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164438

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1a11635 with merge base a10207e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft October 2, 2025 05:54
@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: export labels Oct 2, 2025
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fx labels Oct 2, 2025
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2025
@cyyever cyyever changed the title Ruff 035 7 [6/N] Apply ruff UP035 rule Oct 2, 2025
@cyyever cyyever marked this pull request as ready for review October 2, 2025 11:44
@albanD albanD removed their request for review October 2, 2025 21:53
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the ruff_035_7 branch October 3, 2025 00:17
pytorchmergebot pushed a commit that referenced this pull request Oct 10, 2025
This PR is follow-up of #164438 to continue applying `UP035` rule. All changes are about proper `Callable` importation.

Pull Request resolved: #164653
Approved by: https://github.com/aorenste
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Continued code migration to enable ruff UP035. Most changes are about moving `Callable` from typing to from collections.abc.

Pull Request resolved: pytorch#164438
Approved by: https://github.com/ezyang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
This PR is follow-up of pytorch#164438 to continue applying `UP035` rule. All changes are about proper `Callable` importation.

Pull Request resolved: pytorch#164653
Approved by: https://github.com/aorenste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: export

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants