Closed
Conversation
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164333
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d64dadf with merge base 9ddfc59 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
58f60e1 to
1d76b81
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#164333 Approved by: https://github.com/albanD
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 19, 2025
Summary: Prior to #[164333](#164333), the 32-bit activation range was defined as `(int(-(2**31)), int(2**31 - 1))`. The `int` was deemed unnecessary, however torch.jit.script inteprets 2**31 as a float (example error P2044074770). Instead of reverting to the old definition (introduced by our team in #[150870](#150870), which could be "fixed" again), I replace with the value directly. Test Plan: N8628317 demonstrates the error without this diff. No error on this diff. Differential Revision: D87278420 Pull Request resolved: #168046 Approved by: https://github.com/cyyever, https://github.com/yangw-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies some ruff rules in order to finally enable them.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela