Skip to content

[CI] Push viable/strict/${time} tags#164183

Closed
malfet wants to merge 2 commits intogh/malfet/543/basefrom
gh/malfet/543/head
Closed

[CI] Push viable/strict/${time} tags#164183
malfet wants to merge 2 commits intogh/malfet/543/basefrom
gh/malfet/543/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 29, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Every time viable strict is updated

@malfet
Update
afd4719 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner September 29, 2025 22:47
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164183

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 29 Pending

As of commit 2c5c2fb with merge base 069ccf5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Sep 29, 2025
@malfet
[CI] Push viable/strict/${time} tags
ac77ba9 
Every time viable strict is updated

ghstack-source-id: bfddc7c
Pull Request resolved: #164183
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 29, 2025
jathu
jathu reviewed Sep 29, 2025
View reviewed changes
.github/workflows/update-viablestrict.yml
Comment on lines +51 to +52
# Push new viable/strict tag
git push origin "${LATEST_SHA}:refs/tags/viable/strict/${TIME}"
Copy link
Contributor

@jathu jathu Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps we should create another step instead of coupling it with this aws step. Suppose someone decides to remove this step in the future

@malfet
Copy link
Contributor Author

malfet commented Sep 30, 2025

@pytorchbot merge -f "Lint is green, will see if it works soon enough"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Sep 30, 2025

@pytorchbot revert -m "Hmm, didn't work that way" -c weird

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 30, 2025
@pytorchmergebot
Revert "[CI] Push viable/strict/${time} tags (#164183)"
79fcfd4 
This reverts commit 9f27b0c.

Reverted #164183 on behalf of https://github.com/malfet due to Hmm, didn't work that way ([comment](#164183 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 30, 2025
@malfet
Update
2c5c2fb 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Oct 1, 2025
@malfet
[CI] Push viable/strict/${time} tags
b480b7b 
Every time viable strict is updated

ghstack-source-id: 285a2ef
Pull Request resolved: #164183
@malfet
Copy link
Contributor Author

malfet commented Oct 1, 2025

@pytorchbot merge -f "Take two"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@malfet @Chao1Han
[CI] Push viable/strict/${time} tags (pytorch#164183)
90f0cdd 
Every time viable strict is updated
Pull Request resolved: pytorch#164183
Approved by: https://github.com/seemethere
@github-actions github-actions bot deleted the gh/malfet/543/head branch November 1, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathu jathu jathu left review comments

@seemethere seemethere seemethere approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @seemethere @jathu