[export] Skip the check instead of disable#164084
Closed
anijain2305 wants to merge 7 commits intogh/anijain2305/888/basefrom
Closed
[export] Skip the check instead of disable#164084anijain2305 wants to merge 7 commits intogh/anijain2305/888/basefrom
anijain2305 wants to merge 7 commits intogh/anijain2305/888/basefrom
Conversation
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
This was referenced Sep 28, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164084
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 76a0ad7 with merge base c332d58 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
tugsbayasgalan
approved these changes
Sep 28, 2025
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #164081 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #164081 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Pull Request resolved: #164081 Approved by: https://github.com/tugsbayasgalan ghstack dependencies: #164084
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. Pull Request resolved: #164084 Approved by: https://github.com/tugsbayasgalan
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Pull Request resolved: #164081 Approved by: https://github.com/tugsbayasgalan ghstack dependencies: #164084
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. Pull Request resolved: pytorch#164084 Approved by: https://github.com/tugsbayasgalan
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
…164081) Pull Request resolved: pytorch#164081 Approved by: https://github.com/tugsbayasgalan ghstack dependencies: pytorch#164084
Contributor
|
@pytorchbot revert -m "broke internal tests" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Sep 29, 2025
…164081)" This reverts commit 811c693. Reverted #164081 on behalf of https://github.com/yangw-dev due to broke internal tests ([comment](#164084 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Sep 29, 2025
This reverts commit c2768d0. Reverted #164084 on behalf of https://github.com/yangw-dev due to broke internal tests ([comment](#164084 (comment)))
Collaborator
|
@anijain2305 your PR has been successfully reverted. |
Its unclear why we had disable in the first place. With install_free_tensors, we are tracing into this hook. A better way would be to place the tracer without any hook. For now, disable the checking while dynamo is tracing. [ghstack-poisoned]
Contributor
Author
|
Relanding with #164219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Its unclear why we had disable in the first place. With
install_free_tensors, we are tracing into this hook. A better way would
be to place the tracer without any hook. For now, disable the checking
while dynamo is tracing.