fix flex attention eager: dont round down scores to low-precision (closes #163588) by v0i0 · Pull Request #163986 · pytorch/pytorch

v0i0 · 2025-09-26T19:54:16Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos

…oses #163588) [ghstack-poisoned]

pytorch-bot · 2025-09-26T19:54:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163986

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fbf313f with merge base ad7e3c9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…oses #163588) ghstack-source-id: da14bb2 Pull Request resolved: #163986

drisspg

great catch!

drisspg

@pytorchbot merge

drisspg · 2025-09-30T20:48:44Z

@pytorchbot rebase

pytorchmergebot · 2025-09-30T20:50:12Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

…oses #163588) ghstack-source-id: bb4e700 Pull Request resolved: #163986

pytorchmergebot · 2025-09-30T20:50:24Z

Successfully rebased gh/v0i0/11/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/163986)

drisspg · 2025-09-30T20:50:51Z

@pytorchbot merge

pytorchmergebot · 2025-09-30T20:52:55Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

drisspg · 2025-09-30T20:56:48Z

@pytorchbot merge

pytorchmergebot · 2025-09-30T20:59:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-30T20:59:12Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…ecision (closes #163588)" Fixes: #163588 cc mlazos [ghstack-poisoned]

[ghstack-poisoned]

test/inductor/test_flex_attention.py

v0i0 · 2025-10-02T22:49:48Z

@pytorchbot merge

pytorchmergebot · 2025-10-02T22:51:40Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #164317 Approved by: https://github.com/drisspg ghstack dependencies: #163986

…oses pytorch#163588) (pytorch#163986) Fixes: pytorch#163588 Pull Request resolved: pytorch#163986 Approved by: https://github.com/drisspg, https://github.com/mlazos

Pull Request resolved: pytorch#164317 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#163986

fix flex attention eager: dont round down scores to low-precision (cl…

b26e269

…oses #163588) [ghstack-poisoned]

v0i0 requested a review from zou3519 as a code owner September 26, 2025 19:54

v0i0 added a commit that referenced this pull request Sep 26, 2025

fix flex attention eager: dont round down scores to low-precision (cl…

cfaf819

…oses #163588) ghstack-source-id: da14bb2 Pull Request resolved: #163986

v0i0 mentioned this pull request Sep 26, 2025

Flex Attention Silently Incorrect with bfloat16 and Masks #163588

Closed

v0i0 requested a review from drisspg September 26, 2025 19:59

drisspg approved these changes Sep 30, 2025

View reviewed changes

Update

3a6a1d5

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2025

fix flex attention eager: dont round down scores to low-precision (cl…

5b0fad4

…oses #163588) ghstack-source-id: bb4e700 Pull Request resolved: #163986

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2025

pytorchmergebot added the merging label Sep 30, 2025

pytorchmergebot removed the merging label Sep 30, 2025

drisspg added topic: bug fixes topic category release notes: inductor labels Sep 30, 2025

pytorchmergebot added the merging label Sep 30, 2025

pytorchmergebot removed the merging label Sep 30, 2025

mlazos approved these changes Sep 30, 2025

View reviewed changes

Update on "fix flex attention eager: dont round down scores to low-pr…

9ca8f73

…ecision (closes #163588)" Fixes: #163588 cc mlazos [ghstack-poisoned]

v0i0 mentioned this pull request Oct 1, 2025

fix flex attention eager bwd: more rounding #164317

Closed

v0i0 added 2 commits September 30, 2025 17:14

Update on "fix flex attention eager: dont round down scores to low-pr…

979b8bf

…ecision (closes #163588)" Fixes: #163588 cc mlazos [ghstack-poisoned]

Update

fbf313f

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Oct 2, 2025

v0i0 commented Oct 2, 2025

View reviewed changes

test/inductor/test_flex_attention.py Show resolved Hide resolved

pytorchmergebot added the merging label Oct 2, 2025

pytorchmergebot added the Merged label Oct 3, 2025

pytorchmergebot closed this in 91c4db7 Oct 3, 2025

pytorchmergebot removed the merging label Oct 3, 2025

pytorchmergebot pushed a commit that referenced this pull request Oct 8, 2025

fix flex attention eager bwd: more rounding (#164317)

41808b2

Pull Request resolved: #164317 Approved by: https://github.com/drisspg ghstack dependencies: #163986

pytorchmergebot pushed a commit that referenced this pull request Oct 9, 2025

fix flex attention eager bwd: more rounding (#164317)

a7fa1a9

Pull Request resolved: #164317 Approved by: https://github.com/drisspg ghstack dependencies: #163986

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025

fix flex attention eager bwd: more rounding (pytorch#164317)

8a0b640

Pull Request resolved: pytorch#164317 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#163986

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025

fix flex attention eager bwd: more rounding (pytorch#164317)

136493b

Pull Request resolved: pytorch#164317 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#163986

github-actions bot deleted the gh/v0i0/11/head branch November 2, 2025 02:19

Conversation

v0i0 commented Sep 26, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163986

✅ No Failures

Uh oh!

drisspg left a comment

Choose a reason for hiding this comment

Uh oh!

drisspg left a comment

Choose a reason for hiding this comment

Uh oh!

drisspg commented Sep 30, 2025

Uh oh!

pytorchmergebot commented Sep 30, 2025

Uh oh!

pytorchmergebot commented Sep 30, 2025

Uh oh!

drisspg commented Sep 30, 2025

Uh oh!

pytorchmergebot commented Sep 30, 2025

Merge failed

Uh oh!

drisspg commented Sep 30, 2025

Uh oh!

pytorchmergebot commented Sep 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 30, 2025

Merge failed

Uh oh!

Uh oh!

v0i0 commented Oct 2, 2025

Uh oh!

pytorchmergebot commented Oct 2, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v0i0 commented Sep 26, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 26, 2025 •

edited

Loading