Skip to content

[Code Clean] Remove deadcodes about Python3.9 [3/N]#163629

Closed
fffrog wants to merge 3 commits intogh/fffrog/163/basefrom
gh/fffrog/163/head
Closed

[Code Clean] Remove deadcodes about Python3.9 [3/N]#163629
fffrog wants to merge 3 commits intogh/fffrog/163/basefrom
gh/fffrog/163/head

Conversation

@fffrog
Copy link
Copy Markdown
Collaborator

@fffrog fffrog commented Sep 23, 2025 •
edited
Loading

@fffrog
Update
3d62b02 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163629

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 373be13 with merge base d746b98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fffrog added a commit that referenced this pull request Sep 23, 2025
@fffrog
[Code clean] Remove the deadcode in pythoncapi_compat.h about Python3.9
4ae46dc 
As the title stated.


ghstack-source-id: 23fe07b
Pull-Request: #163629
This was referenced Sep 23, 2025
Closed
Closed
@fffrog
Update
2ce4412 
[ghstack-poisoned]
fffrog added a commit that referenced this pull request Sep 23, 2025
@fffrog
[Code Clean] Remove deadcodes about Python3.9 [3/N]
e64c273 
As the title stated.

ghstack-source-id: b84f6e8
Pull-Request: #163629
@fffrog fffrog changed the title [Code clean] Remove the deadcode in pythoncapi_compat.h about Python3.9 [Code Clean] Remove deadcodes about Python3.9 [3/N] Sep 23, 2025
This was referenced Sep 23, 2025
Closed
Closed
Closed
Closed
@fffrog fffrog requested review from albanD and ezyang September 23, 2025 15:00
albanD
albanD approved these changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fffrog fffrog added the topic: not user facing topic category label Sep 24, 2025
@fffrog
Update
373be13 
[ghstack-poisoned]
@fffrog fffrog mentioned this pull request Sep 24, 2025
Closed
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 24, 2025

Starting merge as part of PR stack under #163646

pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [4/N] (#163643)
ec0cd81 
As the title stated.
Pull Request resolved: #163643
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [5/N] (#163644)
6f34cc0 
As the title stated.
Pull Request resolved: #163644
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [6/N] (#163645)
a635505 
As the title stated.
Pull Request resolved: #163645
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629, #163643, #163644
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [7/N] (#163646)
2390d34 
As the title stated.

Pull Request resolved: #163646
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645
pytorchmergebot pushed a commit that referenced this pull request Sep 25, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [8/N] (#163728)
a213848 
As the title stated.

Pull Request resolved: #163728
Approved by: https://github.com/albanD, https://github.com/cyyever
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645, #163646
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [3/N] (pytorch#163629)
3cbe00a 
As the title stated.
Pull Request resolved: pytorch#163629
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [4/N] (pytorch#163643)
e869ba2 
As the title stated.
Pull Request resolved: pytorch#163643
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [5/N] (pytorch#163644)
7fae4eb 
As the title stated.
Pull Request resolved: pytorch#163644
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [6/N] (pytorch#163645)
6acffb8 
As the title stated.
Pull Request resolved: pytorch#163645
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643, pytorch#163644
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [7/N] (pytorch#163646)
920dcf5 
As the title stated.

Pull Request resolved: pytorch#163646
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643, pytorch#163644, pytorch#163645
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [3/N] (#163629)
81107b0 
As the title stated.
Pull Request resolved: #163629
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [4/N] (#163643)
cc9870d 
As the title stated.
Pull Request resolved: #163643
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [5/N] (#163644)
5ab8bff 
As the title stated.
Pull Request resolved: #163644
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [6/N] (#163645)
7f13bcb 
As the title stated.
Pull Request resolved: #163645
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629, #163643, #163644
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [7/N] (#163646)
d5205ae 
As the title stated.

Pull Request resolved: #163646
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [8/N] (#163728)
2d5e586 
As the title stated.

Pull Request resolved: #163728
Approved by: https://github.com/albanD, https://github.com/cyyever
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645, #163646
@github-actions github-actions Bot deleted the gh/fffrog/163/head branch October 25, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fffrog @pytorchmergebot @albanD @pytorchbot