Skip to content

refactor: replace runtime_error with TORCH_CHECK for better error handling#163628

Closed
licy666 wants to merge 1 commit intopytorch:mainfrom
licy666:autogradFixExp
Closed

refactor: replace runtime_error with TORCH_CHECK for better error handling#163628
licy666 wants to merge 1 commit intopytorch:mainfrom
licy666:autogradFixExp

Conversation

@licy666
Copy link
Contributor

@licy666 licy666 commented Sep 23, 2025

Fixes some parts of issue #148114

@pytorchbot label "topic: not user facing"

@fffrog PTAL

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163628

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 206a821 with merge base d73c283 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@licy666
Copy link
Contributor Author

licy666 commented Sep 23, 2025

@pytorchbot label "topic: not user facing"

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Sep 23, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2025
@fffrog
Copy link
Collaborator

fffrog commented Oct 10, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/main pull/163628/head returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/csrc/autograd/cpp_hook.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/cpp_hook.cpp
Auto-merging torch/csrc/autograd/python_anomaly_mode.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/python_anomaly_mode.cpp
Auto-merging torch/csrc/autograd/python_engine.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/python_engine.cpp
Auto-merging torch/csrc/autograd/python_function.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/python_function.cpp
Auto-merging torch/csrc/autograd/python_hook.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/python_hook.cpp
error: could not apply a3199ff7f71... refactor: replace runtime_error with TORCH_CHECK for better error handling
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply a3199ff7f71... # refactor: replace runtime_error with TORCH_CHECK for better error handling

Raised by https://github.com/pytorch/pytorch/actions/runs/18395990946

@licy666
Copy link
Contributor Author

licy666 commented Oct 13, 2025

@fffrog Rebase success. Please take a look.

@licy666
Copy link
Contributor Author

licy666 commented Oct 16, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@licy666
Copy link
Contributor Author

licy666 commented Oct 16, 2025

@soulitzer, Please take a look. Thank!

@pytorchmergebot
Copy link
Collaborator

Successfully rebased autogradFixExp onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout autogradFixExp && git pull --rebase)

@fffrog
Copy link
Collaborator

fffrog commented Oct 16, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
…dling (pytorch#163628)

Fixes some parts of issue pytorch#148114

@pytorchbot label "topic: not user facing"

@fffrog PTAL
Pull Request resolved: pytorch#163628
Approved by: https://github.com/albanD
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
…dling (pytorch#163628)

Fixes some parts of issue pytorch#148114

@pytorchbot label "topic: not user facing"

@fffrog PTAL
Pull Request resolved: pytorch#163628
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants