[PowerPC] Disable MKLDNN TF32 on PowerPC to fix build failure#163454
[PowerPC] Disable MKLDNN TF32 on PowerPC to fix build failure#163454Tiwari-Avanish wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163454
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 30e7521 with merge base 5c827a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
Hi @jgong5 @mingfeima @albanD @malfet Could you please review this code? I need to push these changes into the 2.9 release branch as well. |
|
Hi, |
|
Thanks @jgong5 for reviewing and approving this PR. Since the contribution requires at least two approvals, could someone else please review this PR as well? |
|
Could you please help review/approve so that we can proceed with merging it into the PyTorch branch? Thanks a lot for your time and support. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
0cb4158 to
da3e719
Compare
|
Hi @jgong5, I accidentally closed this PR earlier, which removed your approval. Could you please review and approve it again? Since I don’t have merge access, once it’s approved, could you also help merge it? I have rebased these changes on top of the latest main. Thanks a lot for your help |
da3e719 to
30e7521
Compare
|
Hi @jgong5, @mingfeima Could you please help me to merge this PR. I have fixed the lint error and push those changes, from now on i will keep in mind the lint error. |
|
Hi @jgong5 @mingfeima @albanD @malfet The PR has received an approval. Could someone with merge access please help in merging it when possible? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…h#163454) The commits f4d8bc4 added TF32 support for x86 CPUs, which causes build failures on PowerPC systems with mkldnn. This patch disables TF32 paths on PowerPC while keeping x86 TF32 support intact, allowing PyTorch to build successfully on PowerPC. I have run the mkldnn test case on PowerPC, and it passed successfully. `pytest test/test_mkldnn.py 87 passed, 2 skipped in 1709.02s (0:28:29` Pull Request resolved: pytorch#163454 Approved by: https://github.com/jgong5, https://github.com/malfet
The commits f4d8bc4 added TF32 support for x86 CPUs,
which causes build failures on PowerPC systems with mkldnn.
This patch disables TF32 paths on PowerPC while keeping x86 TF32 support intact,
allowing PyTorch to build successfully on PowerPC.
I have run the mkldnn test case on PowerPC, and it passed successfully.
pytest test/test_mkldnn.py 87 passed, 2 skipped in 1709.02s (0:28:29cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168