Skip to content

Delete functorch C extension entirely.#163340

Closed
ezyang wants to merge 4 commits intogh/ezyang/3161/basefrom
gh/ezyang/3161/head
Closed

Delete functorch C extension entirely.#163340
ezyang wants to merge 4 commits intogh/ezyang/3161/basefrom
gh/ezyang/3161/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 19, 2025 •
edited by pytorchmergebot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163340

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 68b02be with merge base 8c8416b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Sep 19, 2025
@ezyang
Delete functorch C extension entirely.
09dfa43 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 6d61d76
Pull-Request: #163340
@ezyang ezyang mentioned this pull request Sep 19, 2025
Closed
@ezyang ezyang added the topic: not user facing topic category label Sep 20, 2025
ezyang added a commit that referenced this pull request Sep 20, 2025
@ezyang
Delete functorch C extension entirely.
ecdf2d4 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 00a3b66
Pull-Request: #163340
aorenste
aorenste approved these changes Sep 21, 2025
View reviewed changes
Copy link
Contributor

@aorenste aorenste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@ezyang
Copy link
Contributor Author

ezyang commented Sep 21, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 21, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 21, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor Author

ezyang commented Sep 21, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 21, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 21, 2025

Successfully rebased gh/ezyang/3161/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/163340)

pytorchmergebot pushed a commit that referenced this pull request Sep 21, 2025
@ezyang
Delete functorch C extension entirely.
4b183f9 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: de5f2c3
Pull-Request: #163340
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@ezyang @mansiag05
Delete functorch C extension entirely. (pytorch#163340)
ce5e811 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#163340
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#160236
@wdvr
Copy link
Contributor

wdvr commented Sep 22, 2025

@pytorchmergebot revert -m "temporary revert to pull out #162659" -c ghfirst

@ezyang ezyang changed the base branch from main to gh/ezyang/3161/base September 22, 2025 13:45
ezyang added a commit that referenced this pull request Sep 22, 2025
@ezyang
Delete functorch C extension entirely.
6704246 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: f00c632
Pull-Request: #163340
@ezyang
Copy link
Contributor Author

ezyang commented Sep 22, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@malfet malfet mentioned this pull request Sep 22, 2025
Open
@ezyang
Copy link
Contributor Author

ezyang commented Sep 24, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@ezyang
Update
68b02be 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@ezyang
Delete functorch C extension entirely.
69379db 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 6ce67c9
Pull-Request: #163340
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Successfully rebased gh/ezyang/3161/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/163340)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: Limited CI for symmetric memory tests on H100 / linux-jammy-cuda12.8-py3.10-gcc11-sm90-symm / test (h100-symm-mem, 1, 1, linux.aws.h100.4)

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented Sep 24, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: Limited CI for symmetric memory tests on H100 / linux-jammy-cuda12.8-py3.10-gcc11-sm90-symm / test (h100-symm-mem, 1, 1, linux.aws.h100.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@ezyang @dsashidh
Delete functorch C extension entirely. (pytorch#163340)
0e4609b 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#163340
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#160236
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "Delete functorch C extension entirely. (pytorch#163340)"
d2cd5e5 
This reverts commit 1faf636.

Reverted pytorch#163340 on behalf of https://github.com/wdvr due to temporary revert to pull out pytorch#162659 ([comment](pytorch#163340 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@ezyang @dsashidh
Delete functorch C extension entirely. (pytorch#163340)
748efa8 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#163340
Approved by: https://github.com/aorenste, https://github.com/wdvr, https://github.com/albanD, https://github.com/malfet
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@ezyang @jainapurva
Delete functorch C extension entirely. (#163340)
9688f44 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: #163340
Approved by: https://github.com/aorenste, https://github.com/wdvr, https://github.com/albanD, https://github.com/malfet
@ezyang ezyang mentioned this pull request Oct 8, 2025
Open
@github-actions github-actions bot deleted the gh/ezyang/3161/head branch October 25, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@albanD albanD albanD approved these changes

@wdvr wdvr wdvr approved these changes

@aorenste aorenste aorenste approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@divyanshk divyanshk Awaiting requested review from divyanshk

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh

@sraikund16 sraikund16 Awaiting requested review from sraikund16

@zou3519 zou3519 Awaiting requested review from zou3519

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/h100-symm-mem ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/vllm Merged module: amp (automated mixed precision) autocast module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: inductor (aoti) Reverted skip-pr-sanity-checks topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ezyang @pytorchmergebot @wdvr @malfet @albanD @aorenste