[dynamo][guards] Do not construct entire framelocals dict for LAMBDA_GUARD#162525
Closed
anijain2305 wants to merge 8 commits intogh/anijain2305/869/basefrom
Closed
[dynamo][guards] Do not construct entire framelocals dict for LAMBDA_GUARD#162525anijain2305 wants to merge 8 commits intogh/anijain2305/869/basefrom
anijain2305 wants to merge 8 commits intogh/anijain2305/869/basefrom
Conversation
…GUARD [ghstack-poisoned]
This was referenced Sep 9, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162525
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit a3c4867 with merge base 1c16c18 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
| guard_fn = out["___make_guard_fn"](*closure_vars.values()) | ||
|
|
||
| required_locals = {} | ||
| for var_name in guard_fn.__code__.co_consts: |
Member
There was a problem hiding this comment.
Why co_consts? I'd imagine we should be looking into co_names?
Contributor
Author
There was a problem hiding this comment.
The guard takes L as the input dict, and the not the variable names directly.
williamwen42
approved these changes
Sep 10, 2025
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…for LAMBDA_GUARD" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 5 checks: inductor / inductor-cpu-test / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.24xl.spr-metal), inductor / unit-test / inductor-test / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / inductor-test / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu), inductor / inductor-test / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / inductor-test / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…GUARD (pytorch#162525) Pull Request resolved: pytorch#162525 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162509
Contributor
Author
|
@pytorchbot revert -m "internal tests fail" -c nosignal |
Contributor
Author
|
https://fburl.com/workplace/qiitdlp6 is the failure |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Sep 19, 2025
… LAMBDA_GUARD (#162525)" This reverts commit 5f630d2. Reverted #162525 on behalf of https://github.com/anijain2305 due to internal tests fail ([comment](#162525 (comment)))
Collaborator
|
@anijain2305 your PR has been successfully reverted. |
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…GUARD (pytorch#162525) Pull Request resolved: pytorch#162525 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162509
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
… LAMBDA_GUARD (pytorch#162525)" This reverts commit 5f630d2. Reverted pytorch#162525 on behalf of https://github.com/anijain2305 due to internal tests fail ([comment](pytorch#162525 (comment)))
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…GUARD (pytorch#162525) Pull Request resolved: pytorch#162525 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162509
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
… LAMBDA_GUARD (pytorch#162525)" This reverts commit 5f630d2. Reverted pytorch#162525 on behalf of https://github.com/anijain2305 due to internal tests fail ([comment](pytorch#162525 (comment)))
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…GUARD (pytorch#162525) Pull Request resolved: pytorch#162525 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162509
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
… LAMBDA_GUARD (pytorch#162525)" This reverts commit 5f630d2. Reverted pytorch#162525 on behalf of https://github.com/anijain2305 due to internal tests fail ([comment](pytorch#162525 (comment)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela