Skip to content

Fix missing moves in initJITBindings#162428

Closed
swolchok wants to merge 2 commits intogh/swolchok/833/basefrom
gh/swolchok/833/head
Closed

Fix missing moves in initJITBindings#162428
swolchok wants to merge 2 commits intogh/swolchok/833/basefrom
gh/swolchok/833/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Sep 8, 2025 •
edited by pytorch-bot Bot
Loading

@swolchok
Update
23586e8 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162428

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 451b6b4 with merge base 303f514 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: jit release notes category label Sep 8, 2025
swolchok added a commit that referenced this pull request Sep 8, 2025
@swolchok
Fix missing moves in initJITBindings
240e96a 
Per Skylion007 on #162219


ghstack-source-id: 00ea4c1
Pull-Request: #162428
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 8, 2025
@swolchok swolchok requested a review from Skylion007 September 8, 2025 23:29
@swolchok
format
451b6b4 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 8, 2025
@swolchok
Fix missing moves in initJITBindings
974fe18 
Per Skylion007 on #162219

ghstack-source-id: de3fd28
Pull-Request: #162428
@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Sep 9, 2025

@pytorchbot merge

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 9, 2025

This PR needs to be approved by an authorized maintainer before merge.

@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Sep 9, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 9, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Sep 9, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 9, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable), trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Fix missing moves in initJITBindings (pytorch#162428)
dcf97a1 
Per @Skylion007 on pytorch#162219

Pull Request resolved: pytorch#162428
Approved by: https://github.com/Skylion007
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Fix missing moves in initJITBindings (pytorch#162428)
21e4e3f 
Per @Skylion007 on pytorch#162219

Pull Request resolved: pytorch#162428
Approved by: https://github.com/Skylion007
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Fix missing moves in initJITBindings (pytorch#162428)
209a964 
Per @Skylion007 on pytorch#162219

Pull Request resolved: pytorch#162428
Approved by: https://github.com/Skylion007
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Fix missing moves in initJITBindings (pytorch#162428)
6af531e 
Per @Skylion007 on pytorch#162219

Pull Request resolved: pytorch#162428
Approved by: https://github.com/Skylion007
@github-actions github-actions Bot deleted the gh/swolchok/833/head branch October 10, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @Skylion007 @pytorchmergebot @facebook-github-bot