[inductor] estimate peak memory in codegen only when buffer reuse#162300
Closed
ruisizhang123 wants to merge 1 commit intomainfrom
Closed
[inductor] estimate peak memory in codegen only when buffer reuse#162300ruisizhang123 wants to merge 1 commit intomainfrom
ruisizhang123 wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162300
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 76c5e85 with merge base c321111 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4567595 to
2abf892
Compare
2abf892 to
76c5e85
Compare
eellison
approved these changes
Sep 5, 2025
v0i0
approved these changes
Sep 5, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
daisyden
pushed a commit
to daisyden/pytorch
that referenced
this pull request
Sep 8, 2025
…torch#162300) As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors. The original codegen peak memory estimation code is from this PR: pytorch#159530 Pull Request resolved: pytorch#162300 Approved by: https://github.com/eellison, https://github.com/v0i0
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…torch#162300) As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors. The original codegen peak memory estimation code is from this PR: pytorch#159530 Pull Request resolved: pytorch#162300 Approved by: https://github.com/eellison, https://github.com/v0i0
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162300) As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors. The original codegen peak memory estimation code is from this PR: pytorch#159530 Pull Request resolved: pytorch#162300 Approved by: https://github.com/eellison, https://github.com/v0i0
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162300) As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors. The original codegen peak memory estimation code is from this PR: pytorch#159530 Pull Request resolved: pytorch#162300 Approved by: https://github.com/eellison, https://github.com/v0i0
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…torch#162300) As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors. The original codegen peak memory estimation code is from this PR: pytorch#159530 Pull Request resolved: pytorch#162300 Approved by: https://github.com/eellison, https://github.com/v0i0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled, this PR ensures peak memory is estimated only when buffer reuse is enabled. Without this config, some nodes' successor nodes are eliminated from memory estimation after inductor bucketing, which can cause errors.
The original codegen peak memory estimation code is from this PR: #159530
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben