[inductor][choices] rename get_mm_configs to get_template_configs#162293
Closed
coconutruben wants to merge 9 commits intogh/coconutruben/66/basefrom
Closed
[inductor][choices] rename get_mm_configs to get_template_configs#162293coconutruben wants to merge 9 commits intogh/coconutruben/66/basefrom
coconutruben wants to merge 9 commits intogh/coconutruben/66/basefrom
Conversation
\# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162293
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed46785 with merge base 468c1f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 5, 2025
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
eellison
approved these changes
Sep 5, 2025
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
This was referenced Sep 9, 2025
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pytorchmergebot
added a commit
that referenced
this pull request
Sep 11, 2025
…figs (#162293)" This reverts commit 30191fc. Reverted #162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](#161351 (comment)))
Collaborator
|
@coconutruben your PR has been reverted as part of the stack under #161351. |
…configs" # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]
Contributor
Author
|
@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
Starting merge as part of PR stack under #161468 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 12, 2025
# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: #161468 Approved by: https://github.com/eellison ghstack dependencies: #161351, #161350, #162293
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
why
what
testing
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
Differential Revision: D81820641