Skip to content

[upstream triton] update triton pin to triton 3.5#162278

Closed
davidberard98 wants to merge 5 commits intogh/davidberard98/407/basefrom
gh/davidberard98/407/head
Closed

[upstream triton] update triton pin to triton 3.5#162278
davidberard98 wants to merge 5 commits intogh/davidberard98/407/basefrom
gh/davidberard98/407/head

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Sep 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:

  • this does not include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
  • sam_fast is still failing, so we've disabled it temporarily sam_fast failure with triton 3.5 #162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela @mlazos

@davidberard98 davidberard98 mentioned this pull request Sep 5, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162278

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Unrelated Failures

As of commit 854abd2 with merge base 5da573c (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Sep 5, 2025
davidberard98 added a commit that referenced this pull request Sep 5, 2025
@davidberard98
[upstream triton] update triton pin to triton 3.5
f6bd3a3 
ghstack-source-id: 107ac62
Pull Request resolved: #162278
davidberard98 added a commit that referenced this pull request Sep 5, 2025
@davidberard98
[upstream triton] update triton pin to triton 3.5
773d536 
ghstack-source-id: 31838ad
Pull Request resolved: #162278
@davidberard98 davidberard98 added keep-going Don't stop on first failure, keep running tests until the end release notes: inductor ciflow/rocm Trigger "default" config CI on ROCm ci-no-td Do not run TD on this PR ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/h100 ciflow/rocm-mi355 Trigger "default" config CI on ROCm MI355 runners labels Sep 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

Warning: Unknown label ciflow/rocm-mi355.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/triton_binaries
  • ciflow/inductor
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-perf-test-nightly-rocm
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-cu126
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/periodic-rocm-mi300
  • ciflow/rocm
  • ciflow/rocm-mi300
  • ciflow/s390
  • ciflow/riscv64
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/vllm
  • ciflow/torchbench
  • ciflow/op-benchmark
  • ciflow/pull
  • ciflow/h100
  • ciflow/h100-distributed
  • ciflow/win-arm64
  • ciflow/h100-symm-mem
  • ciflow/h100-cutlass-backend

Please add the new label to .github/pytorch-probot.yml

@davidberard98 davidberard98 mentioned this pull request Sep 5, 2025
Closed
@davidberard98 davidberard98 removed the ciflow/rocm-mi355 Trigger "default" config CI on ROCm MI355 runners label Sep 5, 2025
@davidberard98
Update on "[upstream triton] update triton pin to triton 3.5"
d0359f4 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily #162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela mlazos

[ghstack-poisoned]
@davidberard98 davidberard98 mentioned this pull request Sep 5, 2025
Closed
davidberard98 added a commit that referenced this pull request Sep 5, 2025
@davidberard98
[upstream triton] update triton pin to triton 3.5
a52e0f2 
ghstack-source-id: f7068ce
Pull Request resolved: #162278
@davidberard98
Update on "[upstream triton] update triton pin to triton 3.5"
83e6b31 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily #162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela mlazos

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Sep 5, 2025
@davidberard98
[upstream triton] update triton pin to triton 3.5
a01f84d 
ghstack-source-id: 76470fc
Pull Request resolved: #162278
@davidberard98
Update on "[upstream triton] update triton pin to triton 3.5"
854abd2 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily #162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela mlazos

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Sep 5, 2025
@davidberard98
[upstream triton] update triton pin to triton 3.5
68365e4 
ghstack-source-id: c751cd6
Pull Request resolved: #162278
@davidberard98
Copy link
Contributor Author

davidberard98 commented Sep 8, 2025

@pytorchbot merge -i "Manywheel failures are expected according to Andrey"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: Manywheel failures are expected according to Andrey

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@atalman
Copy link
Contributor

atalman commented Sep 8, 2025

@pytorchmergebot merge -f "all looks good"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@davidberard98 davidberard98 mentioned this pull request Sep 8, 2025
Closed
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Sep 9, 2025
@davidberard98 @facebook-github-bot
update triton pin to triton 3.5 (#162278)
b8e3ab6 
Summary:
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily pytorch/pytorch#162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

X-link: pytorch/pytorch#162278
Approved by: https://github.com/atalman
ghstack dependencies: #162244, #162309

Reviewed By: huydhn

Differential Revision: D81931179

fbshipit-source-id: c76541f3ee65dbc658d61cb639939598615df8c2
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@davidberard98 @markc-614
[upstream triton] update triton pin to triton 3.5 (pytorch#162278)
2ab2e9f 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily pytorch#162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

Pull Request resolved: pytorch#162278
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#162244, pytorch#162309
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@davidberard98 @mansiag05
[upstream triton] update triton pin to triton 3.5 (pytorch#162278)
fe64512 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily pytorch#162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

Pull Request resolved: pytorch#162278
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#162244, pytorch#162309
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@davidberard98 @cleonard530
[upstream triton] update triton pin to triton 3.5 (pytorch#162278)
01cf8d8 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily pytorch#162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

Pull Request resolved: pytorch#162278
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#162244, pytorch#162309
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@davidberard98 @dsashidh
[upstream triton] update triton pin to triton 3.5 (pytorch#162278)
d2706b8 
Update PyTorch to the latest Triton release candidate branch (release/3.5.x in triton-lang/triton)

Notably:
* this does *not* include the version number bump from 3.4 -> 3.5 (we'll do that in a follow-up PR)
* sam_fast is still failing, so we've disabled it temporarily pytorch#162282 and we are committed to fixing it, ideally before the branch cut but possibly as a cherry-pick into the release branch.

Pull Request resolved: pytorch#162278
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#162244, pytorch#162309
@github-actions github-actions bot deleted the gh/davidberard98/407/head branch October 9, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@Chillee Chillee Awaiting requested review from Chillee

@eellison eellison Awaiting requested review from eellison

@shunting314 shunting314 Awaiting requested review from shunting314

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jataylo jataylo Awaiting requested review from jataylo

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/h100 ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo module: inductor release notes: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidberard98 @atalman @pytorchmergebot