[SymmMem] Increase signal pad size for NVL72#162026
Closed
kwen2501 wants to merge 1 commit intogh/kwen2501/226/basefrom
Closed
[SymmMem] Increase signal pad size for NVL72#162026kwen2501 wants to merge 1 commit intogh/kwen2501/226/basefrom
kwen2501 wants to merge 1 commit intogh/kwen2501/226/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162026
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b6bcad5 with merge base 524b78d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
reviewed
Sep 4, 2025
| // Covers NVL72 | ||
| constexpr int max_cuda_p2p_domain_size = 72; | ||
| // Maximum number of channels | ||
| constexpr int symm_max_nblocks = 32; |
Collaborator
There was a problem hiding this comment.
do we ever increase blocks to 32?
Collaborator
Author
There was a problem hiding this comment.
We may need to do so soon for our ops on Blackwell (NV18) due to its large bw.
I will pull a PR on that later.
ngimel
approved these changes
Sep 4, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
so that the signal calls do not step on each other's foot. Pull Request resolved: pytorch#162026 Approved by: https://github.com/ngimel
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
so that the signal calls do not step on each other's foot. Pull Request resolved: pytorch#162026 Approved by: https://github.com/ngimel
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
so that the signal calls do not step on each other's foot. Pull Request resolved: pytorch#162026 Approved by: https://github.com/ngimel
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
so that the signal calls do not step on each other's foot. Pull Request resolved: pytorch#162026 Approved by: https://github.com/ngimel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
so that the signal calls do not step on each other's foot.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim