[FP8][cuBLAS][H100] only test fp32 outputs for rowwise _scaled_mm on H100#162022
Closed
eqy wants to merge 1 commit intopytorch:mainfrom
Closed
[FP8][cuBLAS][H100] only test fp32 outputs for rowwise _scaled_mm on H100#162022eqy wants to merge 1 commit intopytorch:mainfrom
_scaled_mm on H100#162022eqy wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162022
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bf995fe with merge base 5a2da09 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
reviewed
Sep 18, 2025
|
|
||
| # only cuBLAS supports rowwise with fp32 output and cuBLAS only supports | ||
| # rowwise on SM 9.0 | ||
| if torch.cuda.get_device_capability != (9, 0) and output_dtype == torch.float: |
Collaborator
There was a problem hiding this comment.
but H100 is sm_90 so the test should not have been failing?
Collaborator
Author
There was a problem hiding this comment.
This is added by the PR and checks that it indeed fails on non-sm90?
ngimel
approved these changes
Sep 19, 2025
Collaborator
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 21, 2025
@ngimel is right, `ciflow/h100` doesn't actually appear to test the PR :( Pull Request resolved: #163354 Approved by: https://github.com/ngimel, https://github.com/Skylion007
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…n H100 (pytorch#162022) only cuBLAS supports float32 output and cuBLAS only supports rowwise for SM 9.0 Intended to land after pytorch#161305 Pull Request resolved: pytorch#162022 Approved by: https://github.com/ngimel
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
@ngimel is right, `ciflow/h100` doesn't actually appear to test the PR :( Pull Request resolved: pytorch#163354 Approved by: https://github.com/ngimel, https://github.com/Skylion007
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…n H100 (pytorch#162022) only cuBLAS supports float32 output and cuBLAS only supports rowwise for SM 9.0 Intended to land after pytorch#161305 Pull Request resolved: pytorch#162022 Approved by: https://github.com/ngimel
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
@ngimel is right, `ciflow/h100` doesn't actually appear to test the PR :( Pull Request resolved: pytorch#163354 Approved by: https://github.com/ngimel, https://github.com/Skylion007
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…n H100 (pytorch#162022) only cuBLAS supports float32 output and cuBLAS only supports rowwise for SM 9.0 Intended to land after pytorch#161305 Pull Request resolved: pytorch#162022 Approved by: https://github.com/ngimel
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
@ngimel is right, `ciflow/h100` doesn't actually appear to test the PR :( Pull Request resolved: pytorch#163354 Approved by: https://github.com/ngimel, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only cuBLAS supports float32 output and cuBLAS only supports rowwise for SM 9.0
Intended to land after #161305
cc @csarofeen @ptrblck @xwang233