build: Add fallback commands to setup.py#162009
build: Add fallback commands to setup.py#162009seemethere wants to merge 5 commits intogh/seemethere/61/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162009
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 PendingAs of commit a36379f with merge base 4e42aa8 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
setup.py
Outdated
| EMIT_BUILD_WARNING = True | ||
| if arg == "develop": | ||
| print( | ||
| "Redirecting 'python setup.py develop' to 'pip install -e . -v --no-build-isolation'", |
There was a problem hiding this comment.
Should we print warning here:
print_box(
"""
WARNING: Redirecting 'python setup.py develop' to 'pip install -e . -v --no-build-isolation'
"""
)
There was a problem hiding this comment.
I would use print_box but it's defined further down in the file which would require me to move it which I feel like is a bit much for this PR so going to leave as is for now.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f 'mps test failure looks unrelated' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Adds fallback commands for the following: * python setup.py install * python setup.py develop Ideally these should just work and should provide backwards compat. Thought process here is that multiple people rely on these commands and just because setuptools wants to drop support for this I don't think a lot of our downstream users who build from source are expecting these to be gone. This should provide some room for developers to move away from these commands until we have a unified frontend for doing all of these commands that should abstract most of these away. Signed-off-by: Eli Uriegas <eliuriegas@meta.com> Pull Request resolved: pytorch#162009 Approved by: https://github.com/clee2000, https://github.com/atalman
Adds fallback commands for the following: * python setup.py install * python setup.py develop Ideally these should just work and should provide backwards compat. Thought process here is that multiple people rely on these commands and just because setuptools wants to drop support for this I don't think a lot of our downstream users who build from source are expecting these to be gone. This should provide some room for developers to move away from these commands until we have a unified frontend for doing all of these commands that should abstract most of these away. Signed-off-by: Eli Uriegas <eliuriegas@meta.com> Pull Request resolved: pytorch#162009 Approved by: https://github.com/clee2000, https://github.com/atalman
Adds fallback commands for the following: * python setup.py install * python setup.py develop Ideally these should just work and should provide backwards compat Signed-off-by: Eli Uriegas <eliuriegas@meta.com> ghstack-source-id: 1cfb02f Pull-Request: pytorch/pytorch#162009 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Stack from ghstack (oldest at bottom):
Adds fallback commands for the following:
Ideally these should just work and should provide backwards compat.
Thought process here is that multiple people rely on these commands and just because setuptools wants to drop support for this I don't think a lot of our downstream users who build from source are expecting these to be gone.
This should provide some room for developers to move away from these commands until we have a unified frontend for doing all of these commands that should abstract most of these away.
Signed-off-by: Eli Uriegas eliuriegas@meta.com