Skip to content

[BE] Cleanup stale comments/copy from gemm #162001

Closed
malfet wants to merge 1 commit intogh/malfet/505/basefrom
gh/malfet/505/head
Closed

[BE] Cleanup stale comments/copy from gemm #162001
malfet wants to merge 1 commit intogh/malfet/505/basefrom
gh/malfet/505/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 2, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Followup after #154012

Since the introduction of gemm_no_downcast_stub it's no longer necessary to allocate temporary array and then manually implement the beta logic in the codebase

@malfet
Update
8c698aa 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Sep 2, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162001

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8c698aa with merge base 6737e2c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Sep 2, 2025
@malfet
[BE] Cleanup stale comments/copy from the codebase
5371c83 
Followup after #154012

Since the introduction of `gemm_no_downcast_stub` it's no longer
necessary to allocate temporary array and than manually implement the
`beta` logic in the codebase

ghstack-source-id: 47d17e8
Pull Request resolved: #162001
@malfet malfet requested a review from drisspg September 2, 2025 19:58
@malfet malfet added release notes: python_frontend python frontend release notes category topic: improvements topic category labels Sep 2, 2025
@malfet malfet mentioned this pull request Sep 2, 2025
Closed
@malfet malfet changed the title [BE] Cleanup stale comments/copy from the codebase [BE] Cleanup stale comments/copy from gemm Sep 3, 2025
@malfet
Copy link
Contributor Author

malfet commented Sep 3, 2025

@pytorchbot merge -f "All is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 3, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot added a commit that referenced this pull request Sep 4, 2025
@pytorchmergebot
Revert "[BE] Cleanup stale comments/copy from gemm (#162001)"
afa6e56 
This reverts commit b40d943.

Reverted #162001 on behalf of https://github.com/jeanschmidt due to break a few internal tests ([comment](#161999 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

@malfet your PR has been reverted as part of the stack under #161999.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 4, 2025
@malfet
Copy link
Contributor Author

malfet commented Sep 5, 2025

@pytorchbot merge -f "No need for trunk"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Contributor

jeanschmidt commented Sep 7, 2025

@pytorchbot revert -m "breaks internal ads signal, see D81845017" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 7, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 7, 2025
@pytorchmergebot
Revert "[BE] Cleanup stale comments/copy from gemm (#162001)"
df59c21 
This reverts commit 6087ef4.

Reverted #162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](#162001 (comment)))
daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@malfet @daisyden
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
dab355f 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@pytorchmergebot @daisyden
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
5680af0 
This reverts commit 6087ef4.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](pytorch#162001 (comment)))
@malfet
Copy link
Contributor Author

malfet commented Sep 11, 2025

@pytorchbot merge -f "Build failure is bogus"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
c7563bf 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
4720346 
This reverts commit b40d943.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to break a few internal tests ([comment](pytorch#161999 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
8adedf6 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
fab868f 
This reverts commit 6087ef4.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](pytorch#162001 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
a070e7a 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
8d2261c 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
1453073 
This reverts commit b40d943.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to break a few internal tests ([comment](pytorch#161999 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
4fcb9da 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
9e0f0a8 
This reverts commit 6087ef4.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](pytorch#162001 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
a241a40 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
16f5d31 
This reverts commit b40d943.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to break a few internal tests ([comment](pytorch#161999 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
80385fb 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
e9c3e3a 
This reverts commit 6087ef4.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](pytorch#162001 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
61b51b3 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
da8edb1 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
63ba139 
This reverts commit b40d943.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to break a few internal tests ([comment](pytorch#161999 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
79bd2bc 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "[BE] Cleanup stale comments/copy from gemm (pytorch#162001)"
cdb79f8 
This reverts commit 6087ef4.

Reverted pytorch#162001 on behalf of https://github.com/jeanschmidt due to breaks internal ads signal, see [D81845017](https://www.internalfb.com/diff/D81845017) ([comment](pytorch#162001 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[BE] Cleanup stale comments/copy from gemm (pytorch#162001)
05b7444 
Followup after pytorch#154012

Since the introduction of `gemm_no_downcast_stub` it's no longer necessary to allocate temporary array and then manually implement the `beta` logic in the codebase
Pull Request resolved: pytorch#162001
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#161999
@github-actions github-actions bot deleted the gh/malfet/505/head branch October 12, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR Merged release notes: python_frontend python frontend release notes category Reverted topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @jeanschmidt @drisspg