Skip to content

[OpenReg] Add tests of device and memory for OpenReg#161773

Closed
fffrog wants to merge 6 commits intogh/fffrog/146/basefrom
gh/fffrog/146/head
Closed

[OpenReg] Add tests of device and memory for OpenReg#161773
fffrog wants to merge 6 commits intogh/fffrog/146/basefrom
gh/fffrog/146/head

Conversation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161773

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 59eddd1 with merge base d8a0bdb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fffrog added 2 commits August 29, 2025 17:12
[ghstack-poisoned]
[ghstack-poisoned]
@fffrog fffrog requested a review from albanD August 29, 2025 14:47
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.
Do these run in CI? Or only manually?

Also we can focus on python tests for overall behavior as I think that everything should be accessible from python one way or the other.

@fffrog
Copy link
Collaborator Author

fffrog commented Aug 30, 2025

Thank you a lot @albanD

Do these run in CI? Or only manually?

These tests will be run automatically in CI. Because the previous commit was quite large, I've split the OpenReg tests into two parts for easier review. These tests are designed for the OpenReg Accelerator (which is similar to a GPU) and are therefore implemented using gtest in C++.

Also we can focus on python tests for overall behavior as I think that everything should be accessible from python one way or the other.

Yes, the basic functionality of the OpenReg Accelerator is already available, and additional features will be added based on PyTorch integration requirements. Next, we will focus on integrating it into PyTorch and will add relevant tests from Python and documentation.

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #160100

fffrog added 2 commits August 30, 2025 12:02
[ghstack-poisoned]
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #160100

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #160100

pytorchmergebot pushed a commit that referenced this pull request Aug 30, 2025
…160100)

We integrated the openreg backend’s `Stream` and `Event` into PyTorch, all of which are similar
to other accelerators like `CUDA`, `XPUs`, etc.
Pull Request resolved: #160100
Approved by: https://github.com/albanD
ghstack dependencies: #161603, #160099, #161773
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…ytorch#160100)

We integrated the openreg backend’s `Stream` and `Event` into PyTorch, all of which are similar
to other accelerators like `CUDA`, `XPUs`, etc.
Pull Request resolved: pytorch#160100
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#161603, pytorch#160099, pytorch#161773
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
…ytorch#160100)

We integrated the openreg backend’s `Stream` and `Event` into PyTorch, all of which are similar
to other accelerators like `CUDA`, `XPUs`, etc.
Pull Request resolved: pytorch#160100
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#161603, pytorch#160099, pytorch#161773
@github-actions github-actions bot deleted the gh/fffrog/146/head branch September 30, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants