Skip to content

expose number of outputs in native runtime for unified runtime#161723

Closed
JacobSzwejbka wants to merge 4 commits intomainfrom
nativert_numoutputs
Closed

expose number of outputs in native runtime for unified runtime#161723
JacobSzwejbka wants to merge 4 commits intomainfrom
nativert_numoutputs

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17 @SherlockNoMad

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Aug 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161723

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0571ceb with merge base d1706d9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@JacobSzwejbka JacobSzwejbka added the topic: not user facing topic category label Aug 28, 2025
@JacobSzwejbka
Copy link
Copy Markdown
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 3, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / verify-cachebench-cpu-build / build

Details for Dev Infra team Raised by workflow job

@JacobSzwejbka
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@JacobSzwejbka
Copy link
Copy Markdown
Contributor Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

thenumberouscode pushed a commit to thenumberouscode/pytorch that referenced this pull request Sep 6, 2025
…ch#161723)

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17  @SherlockNoMad
Pull Request resolved: pytorch#161723
Approved by: https://github.com/zhxchen17
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…ch#161723)

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17  @SherlockNoMad
Pull Request resolved: pytorch#161723
Approved by: https://github.com/zhxchen17
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
…ch#161723)

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17  @SherlockNoMad
Pull Request resolved: pytorch#161723
Approved by: https://github.com/zhxchen17
thenumberouscode pushed a commit to thenumberouscode/pytorch that referenced this pull request Sep 23, 2025
…ch#161723)

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17  @SherlockNoMad
Pull Request resolved: pytorch#161723
Approved by: https://github.com/zhxchen17
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
…ch#161723)

This is only user outputs which is what we want. Spoke to @zhxchen17 though and it seems like nativeRT might have some bugs on propogating updates to things like input mutation or buffer mutation though. Something to take a look at in a follow up.

Also I have no idea where the nativeRT tests are. Any pointers @zhxchen17  @SherlockNoMad
Pull Request resolved: pytorch#161723
Approved by: https://github.com/zhxchen17
@github-actions github-actions Bot deleted the nativert_numoutputs branch October 4, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants