Skip to content

[BE] Remove the default TORCH_CUDA_ARCH_LIST in CI Docker image#161137

Closed
huydhn wants to merge 2 commits intopytorch:mainfrom
huydhn:cleanup-default-cuda-arch-list
Closed

[BE] Remove the default TORCH_CUDA_ARCH_LIST in CI Docker image#161137
huydhn wants to merge 2 commits intopytorch:mainfrom
huydhn:cleanup-default-cuda-arch-list

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Aug 21, 2025

This doesn't make sense to have this default to Maxwell, which is too old. All other places in CI/CD needs to overwrite this value. IMO, it makes more sense to not set this at all and let CI/CD jobs set it for their own use cases instead. This is partly responsible for the build failure in #160988

@huydhn huydhn requested review from atalman and malfet August 21, 2025 03:54
@huydhn huydhn requested review from a team and jeffdaily as code owners August 21, 2025 03:54
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Aug 21, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161137

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a20765d with merge base 46429be (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor Author

huydhn commented Aug 22, 2025

@pytorchbot merge -f 'CI only change, should be ok to skip trunk'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…rch#161137)

This doesn't make sense to have this default to Maxwell, which is too old.  All other places in CI/CD needs to overwrite this value.  IMO, it makes more sense to not set this at all and let CI/CD jobs set it for their own use cases instead.  This is partly responsible for the build failure in pytorch#160988
Pull Request resolved: pytorch#161137
Approved by: https://github.com/msaroufim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants