Skip to content

[inductor] disable min/max macro on Windows.#161133

Closed
xuhancn wants to merge 2 commits intopytorch:mainfrom
xuhancn:xu_disable_min_max_macro_on_Windows
Closed

[inductor] disable min/max macro on Windows.#161133
xuhancn wants to merge 2 commits intopytorch:mainfrom
xuhancn:xu_disable_min_max_macro_on_Windows

Conversation

@xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Aug 21, 2025 •
edited by pytorch-bot bot
Loading

@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Aug 21, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161133

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 45 Pending

As of commit fe8a3e0 with merge base a825557 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn marked this pull request as ready for review August 21, 2025 03:07
@xuhancn xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Aug 21, 2025
angelayi
angelayi approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@angelayi angelayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the third_party/tensorpipe change?

@xuhancn
Copy link
Collaborator Author

xuhancn commented Aug 21, 2025

@pytorchbot merge -f "original code is passed CI."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 21, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_disable_min_max_macro_on_Windows branch August 21, 2025 19:53
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@xuhancn @markc-614
[inductor] disable min/max macro on Windows. (pytorch#161133)
62b2a25 
Disable min/max macro on Windows.

Pull Request resolved: pytorch#161133
Approved by: https://github.com/angelayi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@jansel jansel Awaiting requested review from jansel

@desertfire desertfire Awaiting requested review from desertfire

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: inductor module: windows Windows support for PyTorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuhancn @pytorchmergebot @angelayi @pytorchbot