test: ensure editable cached wrapper is respected by ezyang · Pull Request #160943 · pytorch/pytorch

ezyang · 2025-08-19T04:43:58Z

Summary

add a test verifying that editing the local cache wrapper is picked up after Dynamo reset

Testing

lintrunner -a (fails: FLAKE8 failure, TEST_HAS_MAIN failure, CODESPELL failure, PYFMT failure)
PYTHONPATH=. python test/inductor/test_codecache.py TestPyCodeCache.test_editable_cached_wrapper -v

https://chatgpt.com/codex/tasks/task_e_68a3aa3fcc9883239b17d1f4250d1e89

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

pytorch-bot · 2025-08-19T04:44:01Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160943

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d86b63 with merge base 1f21f85 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang · 2025-08-19T04:44:54Z

I reviewed the test and it looks basically plausible. It might be a little brittle, but if brittle it will break in an obvious way. Three separate subprocess approach was suggested by me as a fallback; I guess doing it all in process indeed didn't work.

ezyang · 2025-08-31T14:19:39Z

@pytorchbot merge

ezyang · 2025-08-31T14:20:15Z

@pytorchbot merge

pytorchmergebot · 2025-08-31T14:22:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-08-31T16:49:31Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-cuda12.8-cudnn9-py3.10-clang12 / build

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2025-09-01T01:38:51Z

@pytorchbot merge -r

pytorchmergebot · 2025-09-01T01:40:21Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Signed-off-by: Edward Yang <ezyang@meta.com>

pytorchmergebot · 2025-09-01T01:40:23Z

Successfully rebased codex/add-test-for-inductor-local-cache-behavior onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout codex/add-test-for-inductor-local-cache-behavior && git pull --rebase)

pytorchmergebot · 2025-09-01T01:41:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-01T05:01:46Z

Merge failed

Reason: Could not find commit that was pushed before comment 3240629083

Details for Dev Infra team

Raised by workflow job

ezyang · 2025-09-02T01:41:09Z

@pytorchbot merge

pytorchmergebot · 2025-09-02T01:42:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

jeanschmidt · 2025-09-03T14:44:28Z

@pytorchbot revert -m "See D81486248 for details on broken test" -c ghfirst

pytorchmergebot · 2025-09-03T14:46:24Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit bbedc71. Reverted #160943 on behalf of https://github.com/jeanschmidt due to See [D81486248](https://www.internalfb.com/diff/D81486248) for details on broken test ([comment](#160943 (comment)))

pytorchmergebot · 2025-09-03T14:46:39Z

@ezyang your PR has been successfully reverted.

albanD

SGTM

## Summary - add a test verifying that editing the local cache wrapper is picked up after Dynamo reset ## Testing - `lintrunner -a` *(fails: FLAKE8 failure, TEST_HAS_MAIN failure, CODESPELL failure, PYFMT failure)* - `PYTHONPATH=. python test/inductor/test_codecache.py TestPyCodeCache.test_editable_cached_wrapper -v` ------ https://chatgpt.com/codex/tasks/task_e_68a3aa3fcc9883239b17d1f4250d1e89 Pull Request resolved: pytorch#160943 Approved by: https://github.com/xmfan

…0943)" This reverts commit bbedc71. Reverted pytorch#160943 on behalf of https://github.com/jeanschmidt due to See [D81486248](https://www.internalfb.com/diff/D81486248) for details on broken test ([comment](pytorch#160943 (comment)))

…ductor-local-cache-behavior

Signed-off-by: Edward Yang <ezyang@meta.com>

ezyang · 2025-09-18T15:36:54Z

@pytorchbot merge

pytorchmergebot · 2025-09-18T15:42:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

## Summary - add a test verifying that editing the local cache wrapper is picked up after Dynamo reset ## Testing - `lintrunner -a` *(fails: FLAKE8 failure, TEST_HAS_MAIN failure, CODESPELL failure, PYFMT failure)* - `PYTHONPATH=. python test/inductor/test_codecache.py TestPyCodeCache.test_editable_cached_wrapper -v` ------ https://chatgpt.com/codex/tasks/task_e_68a3aa3fcc9883239b17d1f4250d1e89 Pull Request resolved: pytorch#160943 Approved by: https://github.com/xmfan

…0943)" This reverts commit bbedc71. Reverted pytorch#160943 on behalf of https://github.com/jeanschmidt due to See [D81486248](https://www.internalfb.com/diff/D81486248) for details on broken test ([comment](pytorch#160943 (comment)))

## Summary - add a test verifying that editing the local cache wrapper is picked up after Dynamo reset ## Testing - `lintrunner -a` *(fails: FLAKE8 failure, TEST_HAS_MAIN failure, CODESPELL failure, PYFMT failure)* - `PYTHONPATH=. python test/inductor/test_codecache.py TestPyCodeCache.test_editable_cached_wrapper -v` ------ https://chatgpt.com/codex/tasks/task_e_68a3aa3fcc9883239b17d1f4250d1e89 Pull Request resolved: pytorch#160943 Approved by: https://github.com/xmfan, https://github.com/albanD

…0943)" This reverts commit bbedc71. Reverted pytorch#160943 on behalf of https://github.com/jeanschmidt due to See [D81486248](https://www.internalfb.com/diff/D81486248) for details on broken test ([comment](pytorch#160943 (comment)))

## Summary - add a test verifying that editing the local cache wrapper is picked up after Dynamo reset ## Testing - `lintrunner -a` *(fails: FLAKE8 failure, TEST_HAS_MAIN failure, CODESPELL failure, PYFMT failure)* - `PYTHONPATH=. python test/inductor/test_codecache.py TestPyCodeCache.test_editable_cached_wrapper -v` ------ https://chatgpt.com/codex/tasks/task_e_68a3aa3fcc9883239b17d1f4250d1e89 Pull Request resolved: pytorch#160943 Approved by: https://github.com/xmfan, https://github.com/albanD

ezyang added the codex label Aug 19, 2025 — with ChatGPT Codex Connector

pytorch-bot bot added ciflow/inductor module: inductor topic: not user facing topic category labels Aug 19, 2025

github-actions bot requested review from SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm August 19, 2025 04:44

xmfan approved these changes Aug 19, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 31, 2025

pytorchmergebot added the merging label Aug 31, 2025

pytorchmergebot removed the merging label Aug 31, 2025

ezyang and others added 2 commits September 1, 2025 01:40

test: ensure editable cached wrapper is respected

7a80f67

fixup

f4691df

Signed-off-by: Edward Yang <ezyang@meta.com>

pytorchmergebot force-pushed the codex/add-test-for-inductor-local-cache-behavior branch from 5372244 to f4691df Compare September 1, 2025 01:40

pytorchmergebot added the merging label Sep 1, 2025

pytorchmergebot removed the merging label Sep 1, 2025

pytorchmergebot closed this in bbedc71 Sep 2, 2025

pytorchmergebot added Merged and removed merging labels Sep 2, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 3, 2025

pytorchmergebot reopened this Sep 3, 2025

albanD approved these changes Sep 12, 2025

View reviewed changes

ezyang added 2 commits September 18, 2025 11:35

Merge remote-tracking branch 'origin/main' into codex/add-test-for-in…

6c6d301

…ductor-local-cache-behavior

fixup

5d86b63

Signed-off-by: Edward Yang <ezyang@meta.com>

pytorchmergebot added the merging label Sep 18, 2025

pytorchmergebot closed this in 159c214 Sep 18, 2025

pytorchmergebot removed the merging label Sep 18, 2025

github-actions bot deleted the codex/add-test-for-inductor-local-cache-behavior branch October 19, 2025 02:21

Conversation

ezyang commented Aug 19, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

pytorch-bot bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160943

✅ No Failures

Uh oh!

ezyang commented Aug 19, 2025

Uh oh!

ezyang commented Aug 31, 2025

Uh oh!

ezyang commented Aug 31, 2025

Uh oh!

pytorchmergebot commented Aug 31, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 31, 2025

Merge failed

Uh oh!

ezyang commented Sep 1, 2025

Uh oh!

pytorchmergebot commented Sep 1, 2025

Uh oh!

pytorchmergebot commented Sep 1, 2025

Uh oh!

pytorchmergebot commented Sep 1, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 1, 2025

Merge failed

Uh oh!

ezyang commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Merge started

Uh oh!

jeanschmidt commented Sep 3, 2025

Uh oh!

pytorchmergebot commented Sep 3, 2025

Uh oh!

pytorchmergebot commented Sep 3, 2025

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Sep 18, 2025

Uh oh!

pytorchmergebot commented Sep 18, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ezyang commented Aug 19, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 19, 2025 •

edited

Loading