Closed
Conversation
Signed-off-by: Huy Do <huydhn@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160935
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1a3a82d with merge base 4e90441 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
commented
Aug 19, 2025
| with: | ||
| build-environment: linux-jammy-cuda12.8-py3.10-gcc9-sm90 | ||
| dashboard-tag: training-${{ inputs.training }}-inference-${{ inputs.inference }}-default-${{ inputs.default }}-dynamic-${{ inputs.dynamic }}-cudagraphs-${{ inputs.cudagraphs }}-cppwrapper-${{ inputs.cppwrapper }}-aotinductor-${{ inputs.aotinductor }}-maxautotune-${{ inputs.maxautotune }}-freezing_cudagraphs-${{ inputs.freezing_cudagraphs }}-cudagraphs_low_precision-${{ inputs.cudagraphs }} | ||
| dashboard-tag: training-${{ inputs.training || 'true' }}-inference-${{ inputs.inference || 'true' }}-default-${{ inputs.default || 'true' }}-dynamic-${{ inputs.dynamic || 'true' }}-cudagraphs-${{ inputs.cudagraphs || 'true' }}-cppwrapper-${{ inputs.cppwrapper || 'false' }}-aotinductor-${{ inputs.aotinductor || 'false' }}-maxautotune-${{ inputs.maxautotune || 'false' }}-freezing_cudagraphs-${{ inputs.freezing_cudagraphs || 'false' }}-cudagraphs_low_precision-${{ inputs.cudagraphs || 'false' }} |
Contributor
Author
There was a problem hiding this comment.
When running this workflow in PR, we need some default values for these inputs. These are what I usually use, but let me know if it makes sense to you.
Signed-off-by: Huy Do <huydhn@gmail.com>
Contributor
Author
|
@pytorchbot merge -f 'CI only tweak, no need to run trunk jobs' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 27, 2025
I made a mistake in #160935 removing this condition check. This ran the benchmark job twice for schedule jobs, i.e. https://github.com/pytorch/pytorch/actions/runs/17266546494. This was missed during testing because `pull_request` and `workflow_dispatch` were working ok. Pull Request resolved: #161619 Approved by: https://github.com/anijain2305
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
After pytorch#160635, I can see dependabot creating the PR to bump `transformers` version at pytorch#160807. This a good start, but there are several tweaks we need: 1. Run inductor tests on the PR including one round of perf benchmark, which is always needed. So, we need `ciflow/inductor` label and a `pull_request` trigger for the benchmark 2. Per @anijain2305 feedback, we don't need to update patch version. So, I add a rule to ignore it. Again, we would need to test this out after this lands. Pull Request resolved: pytorch#160935 Approved by: https://github.com/anijain2305
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
I made a mistake in pytorch#160935 removing this condition check. This ran the benchmark job twice for schedule jobs, i.e. https://github.com/pytorch/pytorch/actions/runs/17266546494. This was missed during testing because `pull_request` and `workflow_dispatch` were working ok. Pull Request resolved: pytorch#161619 Approved by: https://github.com/anijain2305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #160635, I can see dependabot creating the PR to bump
transformersversion at #160807. This a good start, but there are several tweaks we need:ciflow/inductorlabel and apull_requesttrigger for the benchmark