Skip to content

Use numpy 1.26.2 for Python 3.9 and 3.10#160836

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:onnx_ci
Closed

Use numpy 1.26.2 for Python 3.9 and 3.10#160836
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:onnx_ci

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 17, 2025 •
edited
Loading

Because numpy 1.22.4 had reached EOL 3 years ago.

@cyyever cyyever requested a review from jeffdaily as a code owner August 17, 2025 08:27
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160836

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 7749b91 with merge base d636c18 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 17, 2025
@cyyever cyyever requested a review from justinchuby August 17, 2025 08:27
@cyyever cyyever changed the title Don't install vision for ONNX tests Use numpy 1.26.2 for Python 3.9 and 3.10 Aug 17, 2025
@cyyever cyyever requested a review from albanD August 17, 2025 08:52
malfet
malfet previously approved these changes Aug 17, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it'll work, sure

@malfet malfet added the ci-no-td Do not run TD on this PR label Aug 17, 2025
@malfet
Copy link
Contributor

malfet commented Aug 17, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 17, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the onnx_ci branch August 18, 2025 01:02
@clee2000
Copy link
Contributor

clee2000 commented Aug 18, 2025

@pytorchbot revert -m "broke some inductor jobs? Maybe just update the expected values? Not sure what the policy is for something like this GH job link HUD commit link" -c nosignal

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 18, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 18, 2025
@pytorchmergebot
Revert "Use numpy 1.26.2 for Python 3.9 and 3.10 (#160836)"
3ced4f1 
This reverts commit 7a68d02.

Reverted #160836 on behalf of https://github.com/clee2000 due to broke some inductor jobs? Maybe just update the expected values? Not sure what the policy is for something like this [GH job link](https://github.com/pytorch/pytorch/actions/runs/17024529273/job/48262123844) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/7a68d02292fd7a430b55c5bce3268a33c7ec5055) ([comment](#160836 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 18, 2025

@cyyever your PR has been successfully reverted.

@cyyever cyyever restored the onnx_ci branch August 18, 2025 03:35
@cyyever cyyever reopened this Aug 18, 2025
@malfet malfet self-requested a review August 18, 2025 19:24
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 19, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 19, 2025

Successfully rebased onnx_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout onnx_ci && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 19, 2025 •
edited
Loading

@clee2000 It looks like the inductor errors are unrelated because they are marked flaky.

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 19, 2025

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 19, 2025

Merge started

Your change will be merged while ignoring the following 3 checks: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Aug 19, 2025

@pytorchbot revert -m "It broke inductor tests by improving them" -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 19, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 19, 2025
@pytorchmergebot
Revert "Use numpy 1.26.2 for Python 3.9 and 3.10 (#160836)"
e3ebf36 
This reverts commit 5d9653d.

Reverted #160836 on behalf of https://github.com/malfet due to It broke inductor tests by improving them ([comment](#160836 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 19, 2025

@cyyever your PR has been successfully reverted.

@malfet malfet dismissed their stale review August 19, 2025 13:48

Not sure why merge -I was used...

@malfet
Copy link
Contributor

malfet commented Aug 19, 2025

@cyyever can you elaborate why did you merge -I despite receiving a previous info that this change indeed broke inductor tests?

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 19, 2025

@malfet Sorry I used merge -i because the inductor tests were still flaky after this was revered. It could be that the failures are due to other reasons..

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 20, 2025
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@cyyever @can-gaa-hou
Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)
ce3b888 
Because numpy 1.22.4 had reached EOL 3 years ago.
Pull Request resolved: pytorch#160836
Approved by: https://github.com/malfet
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@pytorchmergebot @can-gaa-hou
Revert "Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)"
f8ede3d 
This reverts commit 7a68d02.

Reverted pytorch#160836 on behalf of https://github.com/clee2000 due to broke some inductor jobs? Maybe just update the expected values? Not sure what the policy is for something like this [GH job link](https://github.com/pytorch/pytorch/actions/runs/17024529273/job/48262123844) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/7a68d02292fd7a430b55c5bce3268a33c7ec5055) ([comment](pytorch#160836 (comment)))
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 4, 2025

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@cyyever @pytorchmergebot
Use numpy 1.26.2 for Python 3.9 and 3.10
7749b91 
Signed-off-by: cyy <cyyever@outlook.com>
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

Successfully rebased onnx_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout onnx_ci && git pull --rebase)

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@cyyever @markc-614
Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)
a0e5e7e 
Because numpy 1.22.4 had reached EOL 3 years ago.
Pull Request resolved: pytorch#160836
Approved by: https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)"
b08a57e 
This reverts commit 7a68d02.

Reverted pytorch#160836 on behalf of https://github.com/clee2000 due to broke some inductor jobs? Maybe just update the expected values? Not sure what the policy is for something like this [GH job link](https://github.com/pytorch/pytorch/actions/runs/17024529273/job/48262123844) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/7a68d02292fd7a430b55c5bce3268a33c7ec5055) ([comment](pytorch#160836 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@cyyever @markc-614
Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)
64dac27 
Because numpy 1.22.4 had reached EOL 3 years ago.
Pull Request resolved: pytorch#160836
Approved by: https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "Use numpy 1.26.2 for Python 3.9 and 3.10 (pytorch#160836)"
6c56844 
This reverts commit 5d9653d.

Reverted pytorch#160836 on behalf of https://github.com/malfet due to It broke inductor tests by improving them ([comment](pytorch#160836 (comment)))
@cyyever cyyever closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby

@albanD albanD Awaiting requested review from albanD

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyyever @malfet @pytorchmergebot @clee2000 @pytorchbot @janeyx99